Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings: Remove patch_url from user_settings_panel. 

We remove patch_url from settings_notifications.user_settings_panel
since realm-level defaults section uses save-discard widget and its
code is separate from user notification settings and we can directly
use "/json/settings" as url in user settings code.
This commit is contained in:
Sahil Batra 2021-10-06 17:15:05 +05:30 committed by Tim Abbott
parent b626513a15
commit 98415808ba
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
static/js/settings_notifications.js
View File

@ -48,10 +48,10 @@ function rerender_ui() {
}
}
function change_notification_setting(setting, value, status_element, url) {
function change_notification_setting(setting, value, status_element) {
const data = {};
data[setting] = value;
settings_ui.do_settings_change(channel.patch, url, data, status_element);
settings_ui.do_settings_change(channel.patch, "/json/settings", data, status_element);
}
function update_desktop_icon_count_display(settings_panel) {
@ -96,7 +96,6 @@ export function set_enable_marketing_emails_visibility() {
export function set_up(settings_panel) {
const container = $(settings_panel.container);
const settings_object = settings_panel.settings_object;
const patch_url = settings_panel.patch_url;
const notification_sound_elem = $(settings_panel.notification_sound_elem);
const for_realm_settings = settings_panel.for_realm_settings;
@ -154,7 +153,6 @@ export function set_up(settings_panel) {
setting_name,
settings_org.get_input_element_value(this),
input_elem.closest(".subsection-parent").find(".alert-notification"),
patch_url,
);
});
@ -201,7 +199,6 @@ export function update_page(settings_panel) {
export function initialize() {
user_settings_panel.container = "#user-notification-settings";
user_settings_panel.settings_object = user_settings;
user_settings_panel.patch_url = "/json/settings";
user_settings_panel.notification_sound_elem = "#user-notification-sound-audio";
user_settings_panel.for_realm_settings = false;
}