Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

stars: Fix flaky test due to message list not yet rendered. 

With combined feed no longer cached, this test became flaky as
it took longer for combined feed to load.

Verified that other tests waiting on `.message-list` don't need
this change.
This commit is contained in:
Aman Agrawal 2024-05-10 17:30:33 +00:00 committed by Tim Abbott
parent 42a6929f5c
commit 97e3015ec1
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
web/e2e-tests/stars.test.ts
View File

@ -34,7 +34,11 @@ async function test_narrow_to_starred_messages(page: Page): Promise<void> {
// Go back to the combined feed view. // Go back to the combined feed view.
await page.click("#left-sidebar-navigation-list .top_left_all_messages"); await page.click("#left-sidebar-navigation-list .top_left_all_messages");
await page.waitForSelector(".message-list .message_row", {visible: true}); const combined_feed_id = await common.get_current_msg_list_id(page, true);
await page.waitForSelector(
`.message-list[data-message-list-id='${combined_feed_id}'] .message_row`,
{visible: true},
);
} }
async function stars_test(page: Page): Promise<void> { async function stars_test(page: Page): Promise<void> {