Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings: Fix saving indicator glitch. 

jQuery's fadeOut() sets display: none using inline CSS.
This was overriden by .alert-notification since it used !important
to override the display: block set in loading.js.  Removing the latter
allows us to remove the !important, and doesn't seem to break anything.

Fixes #15759.
This commit is contained in:
Gittenburg 2020-07-14 22:31:10 +02:00 committed by Tim Abbott
parent c68333040b
commit 953d475274
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
static/js/loading.js
View File

@ -9,8 +9,7 @@ exports.make_indicator = function (outer_container, opts) {
// width calculation, above, returns a result that's a few pixels // width calculation, above, returns a result that's a few pixels
// too small. The container's div will be slightly too small, // too small. The container's div will be slightly too small,
// but that's probably OK for our purposes. // but that's probably OK for our purposes.
outer_container.css({display: 'block', outer_container.css({'white-space': 'nowrap'});
'white-space': 'nowrap'});
container.empty(); container.empty();

2
static/styles/settings.scss
View File

@ -591,7 +591,7 @@ input[type=checkbox] {
} }
.alert-notification { .alert-notification {
display: inline-block !important; display: inline-block;
vertical-align: top; vertical-align: top;
height: auto !important; height: auto !important;
width: auto !important; width: auto !important;