Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

purge-old-deployments: Remove an unnecessary check. 

Deployments whose name is not in the format of a timestamp are
always included in the `recent_deployments` and are not deleted,
hence we don't need to check for them explicitly.
This commit is contained in:
Harshit Bansal 2017-09-23 19:38:47 +00:00 committed by Tim Abbott
parent a6caf30ca7
commit 90f6ffa23d
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
scripts/purge-old-deployments
View File

@ -1,6 +1,5 @@
#!/usr/bin/env python3 #!/usr/bin/env python3
import argparse import argparse
import datetime
import os import os
import subprocess import subprocess
import sys import sys
@ -42,14 +41,11 @@ def get_deployments_to_be_purged(recent_deployments):
for deployment in os.listdir(DEPLOYMENTS_DIR)]) for deployment in os.listdir(DEPLOYMENTS_DIR)])
deployments_to_purge = set() deployments_to_purge = set()
for deployment in all_deployments: for deployment in all_deployments:
# Deployments whose name is not in the format of a timestamp are
# always included in the recent_deployments and are not deleted.
if not os.path.isdir(deployment): if not os.path.isdir(deployment):
# Skip things like uwsgi sockets. # Skip things like uwsgi sockets.
continue continue
try:
datetime.datetime.strptime(deployment, TIMESTAMP_FORMAT)
except ValueError:
# Never purge deployments whose name is not in the format of a timestamp.
continue
if deployment not in recent_deployments: if deployment not in recent_deployments:
deployments_to_purge.add(deployment) deployments_to_purge.add(deployment)
return deployments_to_purge return deployments_to_purge