Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

push_notifs: Remove remaining references to ZULIP_IOS_APP_ID setting.

This commit is contained in:
Greg Price 2023-11-06 11:12:33 -08:00 committed by Tim Abbott
parent a9796ec503
commit 9072ddda05
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/production/mobile-push-notifications.md
View File

@ -246,8 +246,8 @@ push notifications through the new app is quite straightforward:
from Apple's developer console. Set `APNS_SANDBOX=False` and from Apple's developer console. Set `APNS_SANDBOX=False` and
`APNS_CERT_FILE` to be the path of your APNS certificate file in `APNS_CERT_FILE` to be the path of your APNS certificate file in
`/etc/zulip/settings.py`. `/etc/zulip/settings.py`.
- Set the `APNS_TOPIC` and `ZULIP_IOS_APP_ID` settings to the ID for - Set the `APNS_TOPIC` setting to the ID for
your app (for the official Zulip apps, they are both `org.zulip.Zulip`). your app (for the official Zulip apps, it's `org.zulip.Zulip`).
- Restart the Zulip server. - Restart the Zulip server.
[apple-docs]: https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/APNSOverview.html [apple-docs]: https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/APNSOverview.html

2
zerver/tests/test_push_notifications.py
View File

@ -1337,7 +1337,7 @@ class PushNotificationTest(BouncerTestCase):
kind=PushDeviceToken.APNS, kind=PushDeviceToken.APNS,
token=hex_to_b64(token), token=hex_to_b64(token),
user=self.user_profile, user=self.user_profile,
ios_app_id=settings.ZULIP_IOS_APP_ID, ios_app_id="org.zulip.Zulip",
) )
self.remote_tokens = [("cccc", "ffff")] self.remote_tokens = [("cccc", "ffff")]

2
zproject/default_settings.py
View File

@ -403,7 +403,7 @@ POST_MIGRATION_CACHE_FLUSHING = False
APNS_CERT_FILE: Optional[str] = None APNS_CERT_FILE: Optional[str] = None
APNS_SANDBOX = True APNS_SANDBOX = True
APNS_TOPIC = "org.zulip.Zulip" APNS_TOPIC = "org.zulip.Zulip"
ZULIP_IOS_APP_ID = "org.zulip.Zulip" # ZULIP_IOS_APP_ID is obsolete
# Limits related to the size of file uploads; last few in MB. # Limits related to the size of file uploads; last few in MB.
DATA_UPLOAD_MAX_MEMORY_SIZE = 25 * 1024 * 1024 DATA_UPLOAD_MAX_MEMORY_SIZE = 25 * 1024 * 1024