push_notifs: Remove remaining references to ZULIP_IOS_APP_ID setting.

docs/production/mobile-push-notifications.md

@@ -246,8 +246,8 @@ push notifications through the new app is quite straightforward:
   from Apple's developer console. Set `APNS_SANDBOX=False` and
   `APNS_CERT_FILE` to be the path of your APNS certificate file in
   `/etc/zulip/settings.py`.
-- Set the `APNS_TOPIC` and `ZULIP_IOS_APP_ID` settings to the ID for
-  your app (for the official Zulip apps, they are both `org.zulip.Zulip`).
+- Set the `APNS_TOPIC` setting to the ID for
+  your app (for the official Zulip apps, it's `org.zulip.Zulip`).
 - Restart the Zulip server.
 
 [apple-docs]: https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/APNSOverview.html

zerver/tests/test_push_notifications.py

@@ -1337,7 +1337,7 @@ class PushNotificationTest(BouncerTestCase):
                 kind=PushDeviceToken.APNS,
                 token=hex_to_b64(token),
                 user=self.user_profile,
-                ios_app_id=settings.ZULIP_IOS_APP_ID,
+                ios_app_id="org.zulip.Zulip",
             )
 
         self.remote_tokens = [("cccc", "ffff")]

zproject/default_settings.py

@@ -403,7 +403,7 @@ POST_MIGRATION_CACHE_FLUSHING = False
 APNS_CERT_FILE: Optional[str] = None
 APNS_SANDBOX = True
 APNS_TOPIC = "org.zulip.Zulip"
-ZULIP_IOS_APP_ID = "org.zulip.Zulip"
+# ZULIP_IOS_APP_ID is obsolete
 
 # Limits related to the size of file uploads; last few in MB.
 DATA_UPLOAD_MAX_MEMORY_SIZE = 25 * 1024 * 1024