Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

slash commands: Remove /settings command. 

It's easy enough for power keyboard users to just use "g"
to get to settings, and it's certainly easier for
mouse users to just go to the menu.
This commit is contained in:
Steve Howell 2021-07-07 12:50:46 +00:00 committed by Steve Howell
parent 5f684bf119
commit 8ffe22fc15
4 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/subsystems/slash-commands.md
View File

@ -10,7 +10,6 @@ Currently supported slash commands are:
- `/ping` to ping to server and get back the time for the round - `/ping` to ping to server and get back the time for the round
trip. Mainly for testing. trip. Mainly for testing.
- `/fluid-width` and `/fixed-width` to toggle that setting - `/fluid-width` and `/fixed-width` to toggle that setting
- `/settings` to open the settings page
It is important to distinguish slash commands from the It is important to distinguish slash commands from the
[widget system](/subsystems/widgets.md). Slash commands essentially [widget system](/subsystems/widgets.md). Slash commands essentially

6
frontend_tests/node_tests/composebox_typeahead.js
View File

@ -161,11 +161,6 @@ const my_slash = {
text: "translated: /my (Test)", text: "translated: /my (Test)",
}; };
const settings_slash = {
name: "settings",
text: "translated: /settings (Load settings menu)",
};
const sweden_stream = { const sweden_stream = {
name: "Sweden", name: "Sweden",
description: "Cold, mountains and home decor.", description: "Cold, mountains and home decor.",
@ -1522,7 +1517,6 @@ test("typeahead_results", () => {
// Autocomplete by slash commands. // Autocomplete by slash commands.
assert_slash_matches("me", [me_slash]); assert_slash_matches("me", [me_slash]);
assert_slash_matches("settings", [settings_slash]);
// Autocomplete stream by stream name or stream description. // Autocomplete stream by stream name or stream description.
assert_stream_matches("den", [denmark_stream, sweden_stream]); assert_stream_matches("den", [denmark_stream, sweden_stream]);

4
static/js/composebox_typeahead.js
View File

@ -408,10 +408,6 @@ export const slash_commands = [
text: $t({defaultMessage: "/poll Where should we go to lunch today? (Create a poll)"}), text: $t({defaultMessage: "/poll Where should we go to lunch today? (Create a poll)"}),
name: "poll", name: "poll",
}, },
{
text: $t({defaultMessage: "/settings (Load settings menu)"}),
name: "settings",
},
{ {
text: $t({defaultMessage: "/todo (Create a todo list)"}), text: $t({defaultMessage: "/todo (Create a todo list)"}),
name: "todo", name: "todo",

6
static/js/zcommand.js
View File

@ -2,7 +2,6 @@ import $ from "jquery";
import marked from "../third/marked/lib/marked"; import marked from "../third/marked/lib/marked";
import * as browser_history from "./browser_history";
import * as channel from "./channel"; import * as channel from "./channel";
import * as common from "./common"; import * as common from "./common";
import * as feedback_widget from "./feedback_widget"; import * as feedback_widget from "./feedback_widget";
@ -189,11 +188,6 @@ export function process(message_content) {
return true; return true;
} }
if (content === "/settings") {
browser_history.go_to_location("settings/your-account");
return true;
}
// It is incredibly important here to return false // It is incredibly important here to return false
// if we don't see an actual zcommand, so that compose.js // if we don't see an actual zcommand, so that compose.js
// knows this is a normal message. // knows this is a normal message.