Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

composebox_typeahead: Remove deprecated workaround. 

The Chromium bug[1] was fixed in 2015.

[1]: https://bugs.chromium.org/p/chromium/issues/detail?id=32865
This commit is contained in:
Gittenburg 2020-07-24 19:46:33 +02:00 committed by Tim Abbott
parent 21dfe76295
commit 8f99820120
1 changed files with 0 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
static/js/composebox_typeahead.js
View File

@ -262,26 +262,6 @@ function handle_keyup(e) {
} }
} }
// https://stackoverflow.com/questions/3380458/looking-for-a-better-workaround-to-chrome-select-on-focus-bug
function select_on_focus(field_id) {
// A select event appears to trigger a focus event under certain
// conditions in Chrome so we need to protect against infinite
// recursion.
let in_handler = false;
$("#" + field_id).on("focus", () => {
if (in_handler) {
return;
}
in_handler = true;
$("#" + field_id)
.trigger("select")
.one("mouseup", (e) => {
e.preventDefault();
});
in_handler = false;
});
}
exports.split_at_cursor = function (query, input) { exports.split_at_cursor = function (query, input) {
const cursor = input.caret(); const cursor = input.caret();
return [query.slice(0, cursor), query.slice(cursor)]; return [query.slice(0, cursor), query.slice(cursor)];
@ -1060,9 +1040,6 @@ exports.initialize_compose_typeahead = function (selector) {
exports.initialize = function () { exports.initialize = function () {
exports.update_emoji_data(); exports.update_emoji_data();
select_on_focus("stream_message_recipient_stream");
select_on_focus("stream_message_recipient_topic");
select_on_focus("private_message_recipient");
// These handlers are at the "form" level so that they are called after typeahead // These handlers are at the "form" level so that they are called after typeahead
$("form#send_message_form").on("keydown", handle_keydown); $("form#send_message_form").on("keydown", handle_keydown);