From 8f3a0927c3fedadb901e0c9e8bfef3372d4f06c1 Mon Sep 17 00:00:00 2001 From: Vishnu Ks Date: Wed, 23 Jan 2019 05:03:18 +0530 Subject: [PATCH] lint: Ban color names in CSS. We already lint using HSL rather than RGB consistently. --- .stylelintrc | 1 + static/styles/compose.scss | 4 ++-- static/styles/night_mode.scss | 2 +- static/styles/portico.scss | 4 ++-- templates/zerver/emails/email.css | 16 ++++++++-------- version.py | 2 +- 6 files changed, 15 insertions(+), 14 deletions(-) diff --git a/.stylelintrc b/.stylelintrc index 0e1af52989..1f59d95834 100644 --- a/.stylelintrc +++ b/.stylelintrc @@ -62,5 +62,6 @@ # Limit language features "color-no-hex": true, + "color-named": "never", } } diff --git a/static/styles/compose.scss b/static/styles/compose.scss index 7d856ccfb5..d9b273a406 100644 --- a/static/styles/compose.scss +++ b/static/styles/compose.scss @@ -265,7 +265,7 @@ div[id^="message-edit-send-status"], font-size: 17px; font-weight: bold; color: hsl(0, 0%, 0%); - text-shadow: 0 1px 0 white; + text-shadow: 0 1px 0 hsl(0, 0%, 100%); opacity: .2; filter: alpha(opacity=20); float: right; @@ -303,7 +303,7 @@ div[id^="message-edit-send-status"], font-size: 17px; font-weight: bold; color: hsl(0, 0%, 0%); - text-shadow: 0 1px 0 white; + text-shadow: 0 1px 0 hsl(0, 0%, 100%); opacity: .2; filter: alpha(opacity=20); } diff --git a/static/styles/night_mode.scss b/static/styles/night_mode.scss index 47ab0bdc88..018bc2b3e8 100644 --- a/static/styles/night_mode.scss +++ b/static/styles/night_mode.scss @@ -62,7 +62,7 @@ body.night-mode { /* this one makes the border of the reactions highlighted on hovering. */ .message_reaction:hover, .reaction_button:hover { - border-color: white !important; + border-color: hsl(0, 0%, 100%) !important; } /* do not turn the .message_header .stream_label text dark on hover because they're diff --git a/static/styles/portico.scss b/static/styles/portico.scss index 169902eb50..1eaf7f1e03 100644 --- a/static/styles/portico.scss +++ b/static/styles/portico.scss @@ -496,7 +496,7 @@ img.screenshot { .integration { margin-top: 2em; padding-top: 1em; - border-top: 1px dashed black; + border-top: 1px dashed hsl(0, 0%, 0%); } .integration p { @@ -1005,7 +1005,7 @@ a.bottom-signup-button { .team input:checked + label { border: 1px solid hsl(0, 0%, 93%); - border-top: 2px solid yellowgreen; + border-top: 2px solid hsl(80, 61%, 50%); border-bottom-color: hsl(0, 0%, 100%); } diff --git a/templates/zerver/emails/email.css b/templates/zerver/emails/email.css index 60aec92bf2..bc7d2aa99c 100644 --- a/templates/zerver/emails/email.css +++ b/templates/zerver/emails/email.css @@ -185,14 +185,14 @@ a.button:hover { .recipient_block { background-color: #f0f4f5; - border: 1px solid black; + border: 1px solid #000000; margin-bottom: 4px; } .recipient_header { color: #e0dada; background-color: #444444; - border-bottom: 1px solid black; + border-bottom: 1px solid #000000; font-weight: bold; padding: 2px; } @@ -221,13 +221,13 @@ a.button:hover { } .hot_convo_recipient_block { - border: 1px solid black; + border: 1px solid #000000; margin-bottom: 4px; } .hot_convo_recipient_header { background-color: #9ec9ff; - border-bottom: 1px solid black; + border-bottom: 1px solid #000000; font-weight: bold; padding: 2px; } @@ -243,13 +243,13 @@ a.button:hover { } .recipient_block_with_messages { - border: 1px solid black; + border: 1px solid #000000; margin-bottom: 4px; } .recipient_header_with_messages { background-color: #9ecaff; - border-bottom: 1px solid black; + border-bottom: 1px solid #000000; font-weight: bold; padding: 2px; } @@ -261,14 +261,14 @@ a.button:hover { .recipient_block_without_messages { background-color: #f0f4f5; - border: 1px solid black; + border: 1px solid #000000; margin-bottom: 4px; } .recipient_header_without_messages { color: #ffffff; background-color: #444444; - border-bottom: 1px solid black; + border-bottom: 1px solid #000000; font-weight: bold; padding: 2px; } diff --git a/version.py b/version.py index 95adfe8e49..c3cdb2f885 100644 --- a/version.py +++ b/version.py @@ -11,4 +11,4 @@ LATEST_RELEASE_ANNOUNCEMENT = "https://blog.zulip.org/2018/11/07/zulip-1-9-relea # Typically, adding a dependency only requires a minor version bump, and # removing a dependency requires a major version bump. -PROVISION_VERSION = '27.1' +PROVISION_VERSION = '27.2'