Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove the newer_than_pointer_count hack in unread accounting. 

This was a workaround for a number of other bugs we had, but at this
point just serves to make debugging more difficult.

(imported from commit 6662b7854c265bd8016f6c8ce75a095731211a45)
This commit is contained in:
Tim Abbott 2013-05-13 11:36:01 -04:00
parent b7e682b157
commit 8f29a39991
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
zephyr/static/js/zephyr.js
View File

@ -278,13 +278,6 @@ function message_unread(message) {
function update_unread_counts() {
home_unread_messages = 0;
function newer_than_pointer_count(msgids) {
var valid = $.grep(msgids, function (msgid) {
return all_msg_list.get(msgid).id > home_msg_list.selected_id();
});
return valid.length;
}
function only_in_home_view(msgids) {
return $.grep(msgids, function (msgid) {
return home_msg_list.get(msgid) !== undefined;
@ -299,7 +292,7 @@ function update_unread_counts() {
var count = Object.keys(msgs).length;
stream_list.set_count("stream", stream, count);
if (narrow.stream_in_home(stream)) {
home_unread_messages += newer_than_pointer_count(only_in_home_view(Object.keys(msgs)));
home_unread_messages += only_in_home_view(Object.keys(msgs)).length;
}
if (unread_subjects[stream] !== undefined) {
@ -312,7 +305,7 @@ function update_unread_counts() {
var pm_count = 0;
$.each(unread_counts["private"], function(index, obj) {
pm_count += newer_than_pointer_count(only_in_home_view(Object.keys(obj)));
pm_count += only_in_home_view(Object.keys(obj)).length;
});
stream_list.set_count("global", "private-message", pm_count);
home_unread_messages += pm_count;