Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

apply_event: Replace list comprehension with list.remove. 

This should be about 4 times faster, saving something like half a
millisecond on each stream of 10000 subscribers.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg 2019-12-31 08:12:21 -08:00 committed by Tim Abbott
parent bbafced254
commit 8f281c4fc9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/lib/events.py
View File

@ -647,7 +647,7 @@ def apply_event(state: Dict[str, Any],
# Remove our user from the subscribers of the removed subscriptions. # Remove our user from the subscribers of the removed subscriptions.
if include_subscribers: if include_subscribers:
for sub in removed_subs: for sub in removed_subs:
sub['subscribers'] = [id for id in sub['subscribers'] if id != user_profile.id] sub['subscribers'].remove(user_profile.id)
# We must effectively copy the removed subscriptions from subscriptions to # We must effectively copy the removed subscriptions from subscriptions to
# unsubscribe, since we only have the name in our data structure. # unsubscribe, since we only have the name in our data structure.