Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

search: Only move cursor to end of selection if cursor is there already. 

Fixes bug reported here:
https://chat.zulip.org/#narrow/channel/9-issues/topic/Broken.20links.20to.20previous.20messages.3F/near/196462
This commit is contained in:
evykassirer 2024-10-22 15:46:59 -07:00 committed by Tim Abbott
parent 5686233699
commit 8e9c592ce3
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
web/src/search.ts
View File

@ -13,6 +13,7 @@ import * as search_pill from "./search_pill";
import type {SearchPillWidget} from "./search_pill"; import type {SearchPillWidget} from "./search_pill";
import * as search_suggestion from "./search_suggestion"; import * as search_suggestion from "./search_suggestion";
import type {NarrowTerm} from "./state_data"; import type {NarrowTerm} from "./state_data";
import * as util from "./util";
// Exported for unit testing // Exported for unit testing
export let is_using_input_method = false; export let is_using_input_method = false;
@ -24,8 +25,12 @@ let on_narrow_search: OnNarrowSearch;
function set_search_bar_text(text: string): void { function set_search_bar_text(text: string): void {
$("#search_query").text(text); $("#search_query").text(text);
// After setting the text, move the cursor to the end of the line. const current_selection = window.getSelection()!;
window.getSelection()!.modify("move", "forward", "line"); if (current_selection.anchorNode?.isSameNode(util.the($("#search_query")))) {
// After setting the text, move the cursor to the end of the line if
// the cursor is in the search bar.
current_selection.modify("move", "forward", "line");
}
} }
function get_search_bar_text(): string { function get_search_bar_text(): string {