Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

process_queue: For threaded workers, create them when they start. 

Creating the QueueProcessingWorker objects when the ThreadedWorker is
created can lead to a race which caused confusing error messages:

1. A thread tries to call `self.worker = get_worker()`
2. This call raises an exception, which is caught by
   `log_and_exit_if_exception`
3. `log_and_exit_if_exception` sends our process a SIGUSR1, _but
    otherwise swallows the error_.
4. The thread's `.run()` is called, which tries to access
   `self.worker`, which was never set, and throws another exception.
5. The process handles the SIGUSR1, restarting.

Move the creation of the worker to when it is started, so the worker
object does not need to be stored, and possibly have a decoupled
failure.
This commit is contained in:
Alex Vandiver 2024-01-11 21:49:18 +00:00
parent fd559495ab
commit 8dfa6fa735
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
zerver/management/commands/process_queue.py
View File

@ -119,15 +119,13 @@ class ThreadedWorker(threading.Thread):
self.logger = logger self.logger = logger
self.queue_name = queue_name self.queue_name = queue_name
with log_and_exit_if_exception(logger, queue_name, threaded=True):
self.worker = get_worker(queue_name, threaded=True)
@override @override
def run(self) -> None: def run(self) -> None:
with configure_scope() as scope, log_and_exit_if_exception( with configure_scope() as scope, log_and_exit_if_exception(
self.logger, self.queue_name, threaded=True self.logger, self.queue_name, threaded=True
): ):
scope.set_tag("queue_worker", self.worker.queue_name) scope.set_tag("queue_worker", self.queue_name)
self.worker.setup() worker = get_worker(self.queue_name, threaded=True)
logging.debug("starting consuming %s", self.worker.queue_name) worker.setup()
self.worker.start() logging.debug("starting consuming %s", self.queue_name)
worker.start()