Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

org settings: Rename functions for more clarity.

This commit is contained in:
Shubham Dhama 2018-04-01 12:26:18 +05:30 committed by Tim Abbott
parent 7fbf613f89
commit 8d70e59ad0
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
static/js/settings_org.js
View File

@ -98,7 +98,7 @@ function get_subsection_property_types(subsection) {
return; return;
} }
function property_value_element_refers(property_name) { function get_property_value(property_name) {
if (property_name === 'realm_message_content_edit_limit_minutes') { if (property_name === 'realm_message_content_edit_limit_minutes') {
return Math.ceil(page_params.realm_message_content_edit_limit_seconds / 60).toString(); return Math.ceil(page_params.realm_message_content_edit_limit_seconds / 60).toString();
} else if (property_name === 'realm_create_stream_permission') { } else if (property_name === 'realm_create_stream_permission') {
@ -279,7 +279,7 @@ exports.populate_signup_notifications_stream_dropdown = function (stream_list) {
}); });
}; };
function handle_dependent_subsettings(property_name) { function update_dependent_subsettings(property_name) {
if (property_name === 'realm_create_stream_permission' || property_name === 'realm_waiting_period_threshold') { if (property_name === 'realm_create_stream_permission' || property_name === 'realm_waiting_period_threshold') {
set_create_stream_permission_dropdown(); set_create_stream_permission_dropdown();
} else if (property_name === 'realm_allow_message_editing') { } else if (property_name === 'realm_allow_message_editing') {
@ -299,7 +299,7 @@ function discard_property_element_changes(elem) {
var property_name = exports.extract_property_name(elem); var property_name = exports.extract_property_name(elem);
// Check whether the id refers to a property whose name we can't // Check whether the id refers to a property whose name we can't
// extract from element's id. // extract from element's id.
var property_value = property_value_element_refers(property_name); var property_value = get_property_value(property_name);
if (property_value === undefined) { if (property_value === undefined) {
property_value = page_params[property_name]; property_value = page_params[property_name];
} }
@ -312,7 +312,7 @@ function discard_property_element_changes(elem) {
blueslip.error('Element refers to unknown property ' + property_name); blueslip.error('Element refers to unknown property ' + property_name);
} }
handle_dependent_subsettings(property_name); update_dependent_subsettings(property_name);
} }
exports.sync_realm_settings = function (property) { exports.sync_realm_settings = function (property) {
@ -393,7 +393,7 @@ function _set_up() {
var changed_val; var changed_val;
// Check whether the id refers to a property whose name we can't // Check whether the id refers to a property whose name we can't
// extract from element's id. // extract from element's id.
var current_val = property_value_element_refers(property_name); var current_val = get_property_value(property_name);
if (current_val === undefined) { if (current_val === undefined) {
current_val = page_params[property_name]; current_val = page_params[property_name];
} }