From 8d44cd78ec66831a32081da94768f6253c8e1cb9 Mon Sep 17 00:00:00 2001 From: Anders Kaseorg Date: Fri, 22 Jan 2021 17:52:49 -0800 Subject: [PATCH] eslint: Fix unicorn/no-this-assignment. Signed-off-by: Anders Kaseorg --- frontend_tests/node_tests/narrow_activate.js | 3 +-- static/js/composebox_typeahead.js | 9 ++++----- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/frontend_tests/node_tests/narrow_activate.js b/frontend_tests/node_tests/narrow_activate.js index 92e76c47af..bd5646ef9d 100644 --- a/frontend_tests/node_tests/narrow_activate.js +++ b/frontend_tests/node_tests/narrow_activate.js @@ -117,11 +117,10 @@ function test_helper() { function stub_message_list() { message_list.MessageList = function (opts) { - const list = this; this.data = opts.data; this.view = { set_message_offset(offset) { - list.view.offset = offset; + this.offset = offset; }, }; diff --git a/static/js/composebox_typeahead.js b/static/js/composebox_typeahead.js index 4725ac4b27..8d9bf20dbc 100644 --- a/static/js/composebox_typeahead.js +++ b/static/js/composebox_typeahead.js @@ -528,8 +528,7 @@ exports.get_sorted_filtered_items = function (query) { several years ago.) */ - const hacky_this = this; - const fetcher = exports.get_candidates.bind(hacky_this); + const fetcher = exports.get_candidates.bind(this); const big_results = fetcher(query); if (!big_results) { @@ -538,10 +537,10 @@ exports.get_sorted_filtered_items = function (query) { // We are still hacking info onto the "this" from // bootstrap. Yuck. - const completing = hacky_this.completing; - const token = hacky_this.token; + const completing = this.completing; + const token = this.token; - const opts = exports.get_stream_topic_data(hacky_this); + const opts = exports.get_stream_topic_data(this); if (completing === "mention" || completing === "silent_mention") { return exports.filter_and_sort_mentions(big_results.is_silent, token, opts);