From 8bc01c85f16bd7c3f3a00b2e2ddb801052d56a7a Mon Sep 17 00:00:00 2001
From: Keegan McAllister <keegan@humbughq.com>
Date: Tue, 2 Oct 2012 18:17:24 -0400
Subject: [PATCH] Collapse new with old messages when prepending

(imported from commit 0279183c9a2c70b1fe42f60f4423327aaf2dc7b8)
---
 zephyr/jstemplates/zephyr.html |  4 ++--
 zephyr/static/js/zephyr.js     | 23 ++++++++++++++++++++++-
 2 files changed, 24 insertions(+), 3 deletions(-)

diff --git a/zephyr/jstemplates/zephyr.html b/zephyr/jstemplates/zephyr.html
index 03d5623e4f..f5799c801d 100644
--- a/zephyr/jstemplates/zephyr.html
+++ b/zephyr/jstemplates/zephyr.html
@@ -20,7 +20,7 @@
 
 {{#include_recipient}}
 {{#if is_class}}
-<tr>
+<tr class="recipient_row">
     <td colspan="2"
         class="zephyr_label_clickable zephyr_newstyle_class"
         onclick="select_zephyr_by_id({{id}}); narrow_class();">{{display_recipient}}</td>
@@ -28,7 +28,7 @@
         onclick="select_zephyr_by_id({{id}}); narrow_instance();">{{instance}}</td>
 </tr>
 {{else}}
-<tr>
+<tr class="recipient_row">
     <td colspan="3" class="zephyr_label_clickable zephyr_newstyle_pm"
         onclick="select_zephyr_by_id({{id}}); narrow_by_recipient();">Huddle with {{display_reply_to}}</td>
 </tr>
diff --git a/zephyr/static/js/zephyr.js b/zephyr/static/js/zephyr.js
index 4fbf9aa339..5c4ab03bb9 100644
--- a/zephyr/static/js/zephyr.js
+++ b/zephyr/static/js/zephyr.js
@@ -811,8 +811,29 @@ function add_to_table(zephyrs, table_name, filter_function, where) {
     var current_group = [];
     var new_message_groups = [];
 
-    if (where !== 'top')
+    if (where === 'top') {
+        // Assumption: We never get a 'top' update as the first update.
+
+        // Delete the current top message group, and add it back in with these
+        // messages, in order to collapse properly.
+        //
+        // This means we redraw the entire view on each update when narrowed by
+        // instance, which could be a problem down the line.  For now we hope
+        // that instance views will not be very big.
+
+        var top_group = message_groups[table_name][0];
+        var top_messages = [];
+        $.each(top_group, function (index, id) {
+            get_zephyr_row(id, table_name).remove();
+            top_messages.push(zephyr_dict[id]);
+        });
+        zephyrs = zephyrs.concat(top_messages);
+
+        // Delete the leftover recipient label.
+        table.find('.recipient_row:first').remove();
+    } else {
         prev = zephyr_dict[table.find('tr:last-child').attr('zid')];
+    }
 
     $.each(zephyrs, function (index, zephyr) {
         if (! filter_function(zephyr))