Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

alert words: Limit alert word length to 100. 

We do limit the length to 100 in the frontend, but no such check
exists in the backend.

Check that a new alert word has a maximum length of 100 in the
alert_words endpoint.
This commit is contained in:
Divyanshu Agrawal 2020-04-17 22:26:36 +05:30 committed by Tim Abbott
parent c0af648b0c
commit 8a64ed6e20
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/views/alert_words.py
View File

@ -5,7 +5,7 @@ from zerver.models import UserProfile
from zerver.lib.request import has_request_variables, REQ
from zerver.lib.response import json_success
from zerver.lib.validator import check_list, check_string
from zerver.lib.validator import check_list, check_string, check_capped_string
from zerver.lib.actions import do_add_alert_words, do_remove_alert_words
from zerver.lib.alert_words import user_alert_words
@ -19,7 +19,7 @@ def clean_alert_words(alert_words: List[str]) -> List[str]:
@has_request_variables
def add_alert_words(request: HttpRequest, user_profile: UserProfile,
alert_words: List[str]=REQ(validator=check_list(check_string))
alert_words: List[str]=REQ(validator=check_list(check_capped_string(100)))
) -> HttpResponse:
do_add_alert_words(user_profile, clean_alert_words(alert_words))
return json_success({'alert_words': user_alert_words(user_profile)})