mirror of https://github.com/zulip/zulip.git
register_server: Check write access to secrets file when rotate_key.
Using --rotate-key without write access to the secrets file is currently quite painful, since you end up rotating your registration's secret with no local record of it; so effectively you lose your registration and need help from support. We should just prevent this failure mode.
This commit is contained in:
parent
7d0c12aa3a
commit
89a22fb076
|
@ -1,3 +1,4 @@
|
|||
import os
|
||||
import subprocess
|
||||
from argparse import ArgumentParser
|
||||
from typing import Any, Dict
|
||||
|
@ -80,6 +81,8 @@ class Command(ZulipBaseCommand):
|
|||
"contact_email": settings.ZULIP_ADMINISTRATOR,
|
||||
}
|
||||
if options["rotate_key"]:
|
||||
if not os.access(SECRETS_FILENAME, os.W_OK):
|
||||
raise CommandError(f"{SECRETS_FILENAME} is not writable by the current user.")
|
||||
request["new_org_key"] = get_random_string(64)
|
||||
|
||||
print(
|
||||
|
|
Loading…
Reference in New Issue