Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

feature_flags: Remove clicking_notification_causes_narrow. 

This is another one that's been set to true
since 2013.
This commit is contained in:
Steve Howell 2020-02-27 13:16:25 +00:00 committed by Tim Abbott
parent 12ae53f11a
commit 8804c63f5d
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
static/js/feature_flags.js
View File

@ -1,6 +1,5 @@
// The features below have all settled into their final states and can
// be removed when we get a chance
exports.clicking_notification_causes_narrow = true;
exports.reminders_in_message_action_menu = false;
window.feature_flags = exports;

8
static/js/notifications.js
View File

@ -408,9 +408,7 @@ function process_notification(notification) {
});
notification_object.onclick = function () {
notification_object.cancel();
if (feature_flags.clicking_notification_causes_narrow) {
narrow.by_topic(message.id, {trigger: 'notification'});
}
narrow.by_topic(message.id, {trigger: 'notification'});
window.focus();
};
notification_object.onclose = function () {
@ -429,9 +427,7 @@ function process_notification(notification) {
// We don't need to bring the browser window into focus explicitly
// by calling `window.focus()` as well as don't need to clear the
// notification since it is the default behavior in Firefox.
if (feature_flags.clicking_notification_causes_narrow) {
narrow.by_topic(message.id, {trigger: 'notification'});
}
narrow.by_topic(message.id, {trigger: 'notification'});
};
} else {
in_browser_notify(message, title, content, raw_operators, opts);