Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Disable casper tests for alert words. 

As they stand now, alert words tests will cause a race condition with
all subsequent tests which access the UserProfile object these tests
modify. Currently, if we modify alert words, we don't get any
notification from the server, issue reported at #1269. Consequently, we
can't wait on any condition to avoid the race condition. The best option
is to wait for the fix of #1269 and modify the tests in that issue.

Fixes: #1244
This commit is contained in:
Umair Khan 2016-07-19 11:53:09 +05:00 committed by Tim Abbott
parent 139bca720d
commit 87dc96b474
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
frontend_tests/casper_tests/06-settings.js
View File

@ -107,6 +107,14 @@ casper.waitUntilVisible('.edit_bot_form[data-email="1-bot@zulip.com"]', function
); );
}); });
/*
This test needs a modification. As it stands now, it will cause a race
condition with all subsequent tests which access the UserProfile object
this test modifies. Currently, if we modify alert words, we don't get
any notification from the server, issue reported at
https://github.com/zulip/zulip/issues/1269. Consequently, we can't wait
on any condition to avoid the race condition.
casper.waitForSelector('#create_alert_word_form', function () { casper.waitForSelector('#create_alert_word_form', function () {
casper.test.info('Attempting to submit an empty alert word'); casper.test.info('Attempting to submit an empty alert word');
casper.click('#create_alert_word_button'); casper.click('#create_alert_word_button');
@ -131,6 +139,7 @@ casper.waitForSelector('#create_alert_word_form', function () {
casper.test.info('Checking that the element was deleted'); casper.test.info('Checking that the element was deleted');
casper.test.assertDoesntExist('div.alert-word-information-box'); casper.test.assertDoesntExist('div.alert-word-information-box');
}); });
*/
casper.then(function change_default_language() { casper.then(function change_default_language() {
casper.test.info('Changing the default language'); casper.test.info('Changing the default language');