Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

edit streams: Change headings and move filter box. 

The new layout is:

    Add Subscribers

        [input pill] [Add]

    Subscribers             [filter]
    <list of subscribers>
This commit is contained in:
Steve Howell 2022-03-04 10:49:47 +00:00 committed by Tim Abbott
parent 79b9759c0b
commit 87aa318e3a
3 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/stream_edit_subscribers.js
View File

@ -265,7 +265,7 @@ function remove_subscriber({stream_id, target_user_id, list_entry}) {
}
export function update_subscribers_list(sub) {
// This is for the "Stream membership" section of the right panel.
// This is for the "Subscribers" tab of the right panel.
// Render subscriptions only if stream settings is open
if (!hash_util.is_editing_stream(sub.stream_id)) {
blueslip.info("ignoring subscription for stream that is no longer being edited");

15
static/templates/stream_settings/stream_members.hbs
View File

@ -1,18 +1,21 @@
{{#render_subscribers}}
<div class="subscriber_list_settings_container" {{#unless can_access_subscribers}}style="display: none"{{/unless}}>
<h4 class="stream_setting_subsection_title">
{{t "Add subscribers" }}
</h4>
<div class="subscriber_list_settings">
<h3 class="stream_setting_subsection_title float-left">
{{t "Stream membership" }}
</h3>
<div class="subscriber-search float-right">
<input type="text" class="search" placeholder="{{t 'Filter subscribers' }}" />
</div>
<div class="subscriber_list_add float-left">
{{> add_subscribers_form}}
<div class="stream_subscription_request_result"></div>
</div>
<div class="clear-float"></div>
</div>
<div>
<h4 class="inline-block stream_setting_subsection_title">{{t "Subscribers"}}</h4>
<span class="subscriber-search float-right">
<input type="text" class="search" placeholder="{{t 'Filter subscribers' }}" />
</span>
</div>
<div class="subscriber-list-box">
<div class="subscriber_list_container" data-simplebar>
<div class="subscriber_list_loading_indicator"></div>

6
templates/zerver/help/add-or-remove-users-from-a-stream.md
View File

@ -17,7 +17,7 @@ to a stream][configure-invites].
1. Select a stream.
1. Under **Stream membership**, enter a name or email address. The typeahead
1. Under **Add subscribers**, enter a name or email address. The typeahead
will only include users who aren't already subscribed to the stream.
1. Click **Add**.
@ -39,9 +39,9 @@ including streams the admin is not subscribed to.
1. Select a stream.
1. Under **Stream membership**, find the user you would like to remove.
1. Under **Subscribers**, find the user you would like to remove.
1. Click **Unsubscribe** to the right of their email address.
1. Click the **Unsubscribe** button in that row.
{end_tabs}