Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

move_topic_to_stream: Default "Move only this message" in search view. 

Fixes #32106

Default to "Move only this message" select option if the message
is in search view, because the search view by its construction
doesn't guarantee to show all/later messages
in the relevant topic.
This commit is contained in:
bedo 2024-11-14 18:43:25 +02:00
parent ad911ac707
commit 857c00f5cc
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
web/src/stream_popover.js
View File

@ -16,6 +16,7 @@ import {$t, $t_html} from "./i18n.ts";
import * as message_edit from "./message_edit.ts";
import * as message_lists from "./message_lists.ts";
import * as message_view from "./message_view.ts";
import * as narrow_state from "./narrow_state.ts";
import * as popover_menus from "./popover_menus.ts";
import {left_sidebar_tippy_options} from "./popover_menus.ts";
import {web_channel_default_view_values} from "./settings_config.ts";
@ -389,11 +390,20 @@ export async function build_move_topic_to_stream_popover(
const move_limit_buffer = 5;
args.disable_topic_input = !message_edit.is_topic_editable(message, move_limit_buffer);
disable_stream_input = !message_edit.is_stream_editable(message, move_limit_buffer);
args.message_placement = await get_message_placement_in_conversation(
current_stream_id,
topic_name,
message.id,
);
// If message is in a search view, default to "move only this message" option,
// same as if it were the last message in any view.
if (narrow_state.is_search_view()) {
args.message_placement = "last";
}
// Else, default option is based on the message placement in the view.
else {
args.message_placement = await get_message_placement_in_conversation(
current_stream_id,
topic_name,
message.id,
);
}
}
function get_params_from_form() {