Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

build_emoji: Pass around emoji_map data structure less. 

It wasn't used in either of these functions.
This commit is contained in:
Tim Abbott 2018-07-13 21:04:37 +05:30
parent b9f974ba61
commit 85243c525d
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/setup/emoji/build_emoji
View File

@ -93,8 +93,8 @@ def get_success_stamp():
sha1_hexdigest = generate_sha1sum_emoji(ZULIP_PATH) sha1_hexdigest = generate_sha1sum_emoji(ZULIP_PATH)
return os.path.join(EMOJI_CACHE_PATH, sha1_hexdigest, 'emoji', '.success-stamp') return os.path.join(EMOJI_CACHE_PATH, sha1_hexdigest, 'emoji', '.success-stamp')
def generate_sprite_css_files(cache_path, emoji_map, emoji_data): def generate_sprite_css_files(cache_path, emoji_data):
# type: (str, Dict[str, str], List[Dict[str, Any]]) -> None # type: (str, List[Dict[str, Any]]) -> None
# Spritesheet CSS generation code. # Spritesheet CSS generation code.
emoji_positions = "" emoji_positions = ""
for emoji in emoji_data: for emoji in emoji_data:
@ -113,8 +113,8 @@ def generate_sprite_css_files(cache_path, emoji_map, emoji_data):
}) })
sprite_css_file.close() sprite_css_file.close()
def setup_emoji_farm(cache_path, emoji_map, emoji_data): def setup_emoji_farm(cache_path, emoji_data):
# type: (str, Dict[str, str], List[Dict[str, Any]]) -> None # type: (str, List[Dict[str, Any]]) -> None
for emojiset in EMOJISETS: for emojiset in EMOJISETS:
# Copy individual emoji images from npm packages. # Copy individual emoji images from npm packages.
src_emoji_farm = os.path.join( src_emoji_farm = os.path.join(
@ -133,7 +133,7 @@ def setup_emoji_farm(cache_path, emoji_map, emoji_data):
output_sprite_sheet = os.path.join(cache_path, 'sheet_%s_64.png' % (emojiset,)) output_sprite_sheet = os.path.join(cache_path, 'sheet_%s_64.png' % (emojiset,))
run(['cp', input_sprite_sheet, output_sprite_sheet]) run(['cp', input_sprite_sheet, output_sprite_sheet])
generate_sprite_css_files(cache_path, emoji_map, emoji_data) generate_sprite_css_files(cache_path, emoji_data)
def setup_old_emoji_farm(cache_path, emoji_map): def setup_old_emoji_farm(cache_path, emoji_map):
# type: (str, Dict[str, str]) -> None # type: (str, Dict[str, str]) -> None
@ -245,7 +245,7 @@ def dump_emojis(cache_path):
# Setup emoji farms. # Setup emoji farms.
run(['rm', '-rf', cache_path]) run(['rm', '-rf', cache_path])
setup_emoji_farm(cache_path, emoji_map, emoji_data) setup_emoji_farm(cache_path, emoji_data)
setup_old_emoji_farm(cache_path, emoji_map) setup_old_emoji_farm(cache_path, emoji_map)
# Generate various map files. # Generate various map files.