Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

resize: Don't use `visible` selector to find element states. 

This change decreases the time required to open compose
after clicking a message. The amount of time reduced varies with pc.

The time reduction was around 0.4s to 0.6s for me after using a
6x CPU slowdown. This may not sound convincing but the profile
uploaded in #21979 clearly shows the root cause of having a message
click take 10s was the `:visible` query.

Fixes #21979
This commit is contained in:
Aman Agrawal 2022-05-03 13:31:14 +00:00 committed by Tim Abbott
parent dbd03b5054
commit 814abf6764
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/resize.js
View File

@ -2,6 +2,7 @@ import autosize from "autosize";
import $ from "jquery"; import $ from "jquery";
import * as blueslip from "./blueslip"; import * as blueslip from "./blueslip";
import * as compose_state from "./compose_state";
import * as condense from "./condense"; import * as condense from "./condense";
import * as message_lists from "./message_lists"; import * as message_lists from "./message_lists";
import * as message_viewport from "./message_viewport"; import * as message_viewport from "./message_viewport";
@ -171,8 +172,7 @@ export function reset_compose_message_max_height(bottom_whitespace_height) {
bottom_whitespace_height = h.bottom_whitespace_height; bottom_whitespace_height = h.bottom_whitespace_height;
} }
// Take properties of the whichever message area is visible. const $visible_textarea = $("#compose-textarea, #preview_message_area");
const $visible_textarea = $("#compose-textarea:visible, #preview_message_area:visible");
const compose_height = Number.parseInt($("#compose").outerHeight(), 10); const compose_height = Number.parseInt($("#compose").outerHeight(), 10);
const compose_textarea_height = Number.parseInt($visible_textarea.outerHeight(), 10); const compose_textarea_height = Number.parseInt($visible_textarea.outerHeight(), 10);
const compose_non_textarea_height = compose_height - compose_textarea_height; const compose_non_textarea_height = compose_height - compose_textarea_height;
@ -196,7 +196,7 @@ export function resize_bottom_whitespace(h) {
// reset_compose_message_max_height cannot compute the right // reset_compose_message_max_height cannot compute the right
// height correctly while compose is hidden. This is OK, because // height correctly while compose is hidden. This is OK, because
// we also resize compose every time it is opened. // we also resize compose every time it is opened.
if ($(".message_comp").is(":visible")) { if (compose_state.composing()) {
reset_compose_message_max_height(h.bottom_whitespace_height); reset_compose_message_max_height(h.bottom_whitespace_height);
} }
} }