Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor: Extract `RESOLVED_TOPIC_PREFIX` in topic.py. 

This is a prep commit for #18990.
This commit is contained in:
akshatdalton 2021-07-13 07:37:57 +00:00 committed by Tim Abbott
parent db476bdc51
commit 7ec406f39d
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/lib/actions.py
View File

@ -158,6 +158,7 @@ from zerver.lib.timezone import canonicalize_timezone
from zerver.lib.topic import ( from zerver.lib.topic import (
LEGACY_PREV_TOPIC, LEGACY_PREV_TOPIC,
ORIG_TOPIC, ORIG_TOPIC,
RESOLVED_TOPIC_PREFIX,
TOPIC_LINKS, TOPIC_LINKS,
TOPIC_NAME, TOPIC_NAME,
filter_by_exact_message_topic, filter_by_exact_message_topic,
@ -5697,9 +5698,6 @@ class MessageUpdateUserInfoResult(TypedDict):
mention_user_ids: Set[int] mention_user_ids: Set[int]
RESOLVED_TOPIC_PREFIX = "✔ "
def maybe_send_resolve_topic_notifications( def maybe_send_resolve_topic_notifications(
*, *,
user_profile: UserProfile, user_profile: UserProfile,

3
zerver/lib/topic.py
View File

@ -16,6 +16,9 @@ TOPIC_NAME = "subject"
TOPIC_LINKS = "topic_links" TOPIC_LINKS = "topic_links"
MATCH_TOPIC = "match_subject" MATCH_TOPIC = "match_subject"
# Prefix use to mark topic as resolved.
RESOLVED_TOPIC_PREFIX = "✔ "
# This constant is actually embedded into # This constant is actually embedded into
# the JSON data for message edit history, # the JSON data for message edit history,
# so we'll always need to handle legacy data # so we'll always need to handle legacy data

3
zerver/tests/test_message_edit.py
View File

@ -9,7 +9,6 @@ from django.http import HttpResponse
from django.utils.timezone import now as timezone_now from django.utils.timezone import now as timezone_now
from zerver.lib.actions import ( from zerver.lib.actions import (
RESOLVED_TOPIC_PREFIX,
do_change_stream_post_policy, do_change_stream_post_policy,
do_change_user_role, do_change_user_role,
do_delete_messages, do_delete_messages,
@ -21,7 +20,7 @@ from zerver.lib.actions import (
from zerver.lib.message import MessageDict, has_message_access, messages_for_ids from zerver.lib.message import MessageDict, has_message_access, messages_for_ids
from zerver.lib.test_classes import ZulipTestCase from zerver.lib.test_classes import ZulipTestCase
from zerver.lib.test_helpers import cache_tries_captured, queries_captured from zerver.lib.test_helpers import cache_tries_captured, queries_captured
from zerver.lib.topic import LEGACY_PREV_TOPIC, TOPIC_NAME from zerver.lib.topic import LEGACY_PREV_TOPIC, RESOLVED_TOPIC_PREFIX, TOPIC_NAME
from zerver.models import Message, Realm, Stream, UserMessage, UserProfile, get_realm, get_stream from zerver.models import Message, Realm, Stream, UserMessage, UserProfile, get_realm, get_stream