Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

subs: Rename `in_home_view` checkbox-setting template element.

This commit is contained in:
Yashashvi Dave 2019-05-21 14:16:42 +05:30 committed by Tim Abbott
parent 2a943d3b40
commit 7d75cdef7f
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
static/js/stream_edit.js
View File

@ -239,10 +239,10 @@ exports.show_settings_for = function (node) {
show_subscription_settings(sub_settings); show_subscription_settings(sub_settings);
}; };
function stream_home_view_clicked(e) { function stream_is_muted_clicked(e) {
var sub = get_sub_for_target(e.target); var sub = get_sub_for_target(e.target);
if (!sub) { if (!sub) {
blueslip.error('stream_home_view_clicked() fails'); blueslip.error('stream_is_muted_clicked() fails');
return; return;
} }
@ -487,8 +487,8 @@ exports.initialize = function () {
e.stopPropagation(); e.stopPropagation();
}); });
$("#subscriptions_table").on("click", "#sub_setting_not_in_home_view", $("#subscriptions_table").on("click", "#sub_setting_is_muted",
stream_home_view_clicked); stream_is_muted_clicked);
$("#subscriptions_table").on("click", "#sub_desktop_notifications_setting", $("#subscriptions_table").on("click", "#sub_desktop_notifications_setting",
stream_desktop_notifications_clicked); stream_desktop_notifications_clicked);
$("#subscriptions_table").on("click", "#sub_audible_notifications_setting", $("#subscriptions_table").on("click", "#sub_audible_notifications_setting",

4
static/js/stream_muting.js
View File

@ -48,8 +48,8 @@ exports.update_is_muted = function (sub, value) {
stream_list.set_in_home_view(sub.stream_id, !sub.is_muted); stream_list.set_in_home_view(sub.stream_id, !sub.is_muted);
var not_in_home_view_checkbox = $(".subscription_settings[data-stream-id='" + sub.stream_id + "'] #sub_setting_not_in_home_view .sub_setting_control"); var is_muted_checkbox = $(".subscription_settings[data-stream-id='" + sub.stream_id + "'] #sub_setting_is_muted .sub_setting_control");
not_in_home_view_checkbox.prop('checked', value); is_muted_checkbox.prop('checked', value);
}; };
return exports; return exports;

2
static/templates/subscription_settings.handlebars
View File

@ -49,7 +49,7 @@
<div class="subscription-config"> <div class="subscription-config">
<ul class="grey-box"> <ul class="grey-box">
<li> <li>
<div id="sub_setting_not_in_home_view" class="sub_setting_checkbox sub-mute-setting"> <div id="sub_setting_is_muted" class="sub_setting_checkbox sub-mute-setting">
<input id="mutestream-{{stream_id}}" class="sub_setting_control" type="checkbox" tabindex="-1" {{#if is_muted}}checked{{/if}} /> <input id="mutestream-{{stream_id}}" class="sub_setting_control" type="checkbox" tabindex="-1" {{#if is_muted}}checked{{/if}} />
<label class="subscription-control-label">{{t "Mute stream" }}</label> <label class="subscription-control-label">{{t "Mute stream" }}</label>
<p class="mute-note {{#unless is_muted}}hide-mute-note{{/unless}}">{{t "Muted streams don't show up in \"All messages\" or generate notifications unless you are mentioned." }}</p> <p class="mute-note {{#unless is_muted}}hide-mute-note{{/unless}}">{{t "Muted streams don't show up in \"All messages\" or generate notifications unless you are mentioned." }}</p>