docs: Correct more “webapp” to “web app”.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2022-09-08 13:51:43 -07:00 committed by Tim Abbott
parent 4c38b1371b
commit 7d485aa58f
7 changed files with 19 additions and 15 deletions

View File

@ -263,7 +263,7 @@ Your pull request will likely go through several stages of review.
progress on the PR by getting more frequent feedback. A project maintainer progress on the PR by getting more frequent feedback. A project maintainer
may leave a comment asking someone with expertise in the area you're working may leave a comment asking someone with expertise in the area you're working
on to review your work. on to review your work.
5. Final code review and integration for server and webapp PRs is generally done 5. Final code review and integration for server and web app PRs is generally done
by `@timabbott`. by `@timabbott`.
#### How to help move the review process forward #### How to help move the review process forward

View File

@ -200,7 +200,7 @@ If the PR makes any frontend changes, you should make sure to play with the part
of the app being changed to validate that things look and work as expected. of the app being changed to validate that things look and work as expected.
While not all of the situations below will apply, here are some ideas for things While not all of the situations below will apply, here are some ideas for things
that should be tested if they are applicable. Use the [development that should be tested if they are applicable. Use the [development
environment][development-environment] to test any webapp changes. environment][development-environment] to test any web app changes.
This might seem like a long process, but you can go through it quite quickly This might seem like a long process, but you can go through it quite quickly
once you get the hang of it. Trust us, it will save time and review round-trips once you get the hang of it. Trust us, it will save time and review round-trips
@ -265,7 +265,7 @@ Some scenarios to consider:
- Try clicking on any interactive elements, multiple times, in a variety of orders. - Try clicking on any interactive elements, multiple times, in a variety of orders.
- If the feature affects the **message view**, try it out in different types of - If the feature affects the **message view**, try it out in different types of
narrows: topic, stream, All messages, PMs. narrows: topic, stream, All messages, PMs.
- If the feature affects the **compose box** in the webapp, try both ways of - If the feature affects the **compose box** in the web app, try both ways of
[resizing the compose box](https://zulip.com/help/resize-the-compose-box). [resizing the compose box](https://zulip.com/help/resize-the-compose-box).
Test both stream messages and PMs. Test both stream messages and PMs.
- If the feature might require **elevated permissions**, check it out as a user who has - If the feature might require **elevated permissions**, check it out as a user who has

View File

@ -574,24 +574,24 @@ export function parse({raw_content, helper_config}) {
return parse_with_options({raw_content, helper_config, options}); return parse_with_options({raw_content, helper_config, options});
} }
// NOTE: Everything below this line is likely to be webapp-specific // NOTE: Everything below this line is likely to be web-specific
// and won't be used by future platforms such as mobile. // and won't be used by future platforms such as mobile.
// We may eventually move this code to a new file, but we want // We may eventually move this code to a new file, but we want
// to wait till the dust settles a bit on some other changes first. // to wait till the dust settles a bit on some other changes first.
let webapp_helpers; let web_app_helpers;
export function initialize(helper_config) { export function initialize(helper_config) {
// This is generally only intended to be called by the webapp. Most // This is generally only intended to be called by the web app. Most
// other platforms should call setup(). // other platforms should call setup().
webapp_helpers = helper_config; web_app_helpers = helper_config;
} }
export function apply_markdown(message) { export function apply_markdown(message) {
// This is generally only intended to be called by the webapp. Most // This is generally only intended to be called by the web app. Most
// other platforms should call parse(). // other platforms should call parse().
const raw_content = message.raw_content; const raw_content = message.raw_content;
const {content, flags} = parse({raw_content, helper_config: webapp_helpers}); const {content, flags} = parse({raw_content, helper_config: web_app_helpers});
message.content = content; message.content = content;
message.flags = flags; message.flags = flags;
message.is_me_message = is_status_message(raw_content); message.is_me_message = is_status_message(raw_content);
@ -604,14 +604,14 @@ export function add_topic_links(message) {
} }
message.topic_links = get_topic_links({ message.topic_links = get_topic_links({
topic: message.topic, topic: message.topic,
get_linkifier_map: webapp_helpers.get_linkifier_map, get_linkifier_map: web_app_helpers.get_linkifier_map,
}); });
} }
export function contains_backend_only_syntax(content) { export function contains_backend_only_syntax(content) {
return content_contains_backend_only_syntax({ return content_contains_backend_only_syntax({
content, content,
get_linkifier_map: webapp_helpers.get_linkifier_map, get_linkifier_map: web_app_helpers.get_linkifier_map,
}); });
} }
@ -620,5 +620,5 @@ export function parse_non_message(raw_content) {
// a message, but we want to convert it to HTML. Note that we parse // a message, but we want to convert it to HTML. Note that we parse
// raw_content exactly as if it were a Zulip message, so we will // raw_content exactly as if it were a Zulip message, so we will
// handle things like mentions, stream links, and linkifiers. // handle things like mentions, stream links, and linkifiers.
return parse({raw_content, helper_config: webapp_helpers}).content; return parse({raw_content, helper_config: web_app_helpers}).content;
} }

View File

@ -31,7 +31,7 @@ Zulip Cloud organizations are always updated to the latest version of Zulip.
## Zulip desktop app version ## Zulip desktop app version
The [Zulip desktop app](/apps/) has an independent version from the server and The [Zulip desktop app](/apps/) has an independent version from the server and
webapp. web app.
### View Zulip desktop app version ### View Zulip desktop app version

View File

@ -76,6 +76,10 @@ whitespace_rules: List["Rule"] = [
"pattern": "\t", "pattern": "\t",
"description": "Fix tab-based whitespace", "description": "Fix tab-based whitespace",
}, },
{
"pattern": r"(?i:webapp)",
"description": "Web app should be two words",
},
] ]
comma_whitespace_rule: List["Rule"] = [ comma_whitespace_rule: List["Rule"] = [
{ {

View File

@ -3,7 +3,7 @@
{ {
"nouns":["server", "FAILED EXPORT", "RECENT TOPICS", "laptop", "BOTS", "router", "bridge", "nouns":["server", "FAILED EXPORT", "RECENT TOPICS", "laptop", "BOTS", "router", "bridge",
"cat5", "nas", "MOBILE", "file server", "API", "wifi", "printer", "cat5", "nas", "MOBILE", "file server", "API", "wifi", "printer",
"plotter", "WEBAPP", "desktop", "PLOTS", "database", "URLS", "keurig"], "plotter", "WEB APP", "desktop", "PLOTS", "database", "URLS", "keurig"],
"adjectives": ["new", "LAST", "old", "first", "NEW", "last", "big", "little", "adjectives": ["new", "LAST", "old", "first", "NEW", "last", "big", "little",
"leased", "FIRST", "owned", "red", "blue", "OLD", "green"], "leased", "FIRST", "owned", "red", "blue", "OLD", "green"],

View File

@ -324,7 +324,7 @@ class HomeTest(ZulipTestCase):
self.assertEqual(result.status_code, 302) self.assertEqual(result.status_code, 302)
self.assertEqual(result["Location"], "/login/") self.assertEqual(result["Location"], "/login/")
# Load webapp directly if spectator access is enabled. # Load web app directly if spectator access is enabled.
do_set_realm_property(realm, "enable_spectator_access", True, acting_user=None) do_set_realm_property(realm, "enable_spectator_access", True, acting_user=None)
result = self.client_get("/") result = self.client_get("/")
self.assertEqual(result.status_code, 200) self.assertEqual(result.status_code, 200)