Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

recent topics: Revert time format changes for now. 

As detailed in this conversation:

https://chat.zulip.org/#narrow/stream/137-feedback/topic/recent.20topics.20timestamps/near/1337670

This time format change is not working out as an improvement for at
least some users, myself included.

I think we do want to use some of the refinements attempted here (and
in particular, I'm keeping the new function with its nice test suite),
but I think it's better to revert now and fix forward in a future
release.

See #19775 for added background.
This commit is contained in:
Tim Abbott 2022-03-21 15:58:03 -07:00 committed by Tim Abbott
parent 040363f6c7
commit 7bc0e70693
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend_tests/node_tests/recent_topics.js
View File

@ -116,7 +116,7 @@ mock_esm("../../static/js/stream_list", {
handle_narrow_deactivated: noop,
});
mock_esm("../../static/js/timerender", {
format_time_modern: () => "Just now",
last_seen_status_from_date: () => "Just now",
get_full_datetime: () => "date at time",
});
mock_esm("../../static/js/sub_store", {

2
static/js/recent_topics_ui.js
View File

@ -253,7 +253,7 @@ function format_topic(topic_data) {
}
const topic = last_msg.topic;
const time = new Date(last_msg.timestamp * 1000);
const last_msg_time = timerender.format_time_modern(time);
const last_msg_time = timerender.last_seen_status_from_date(time);
const full_datetime = timerender.get_full_datetime(time);
// We hide the row according to filters or if it's muted.