Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

compose_pm_pill: Fix `compose_recipient` being mocked but not used. 

While running test for `compose_pm_pill` we get warning that
`compose_recipient` is mocked but never used.
This bug was introduced in #26052.
This commit is contained in:
Aman Agrawal 2023-07-03 09:18:47 +05:30 committed by Tim Abbott
parent d547b838ac
commit 7b6d549604
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
web/tests/compose_pm_pill.test.js
View File

@ -6,7 +6,6 @@ const {mock_esm, zrequire} = require("./lib/namespace");
const {run_test} = require("./lib/test"); const {run_test} = require("./lib/test");
const $ = require("./lib/zjquery"); const $ = require("./lib/zjquery");
const compose_recipient = mock_esm("../src/compose_recipient");
const input_pill = mock_esm("../src/input_pill"); const input_pill = mock_esm("../src/input_pill");
const people = zrequire("people"); const people = zrequire("people");
@ -17,8 +16,6 @@ let pills = {
}; };
run_test("pills", ({override}) => { run_test("pills", ({override}) => {
override(compose_recipient, "update_placeholder_text", () => {});
const othello = { const othello = {
user_id: 1, user_id: 1,
email: "othello@example.com", email: "othello@example.com",
@ -144,19 +141,22 @@ run_test("pills", ({override}) => {
// We stub the return value of input_pill.create(), manually add widget functions to it. // We stub the return value of input_pill.create(), manually add widget functions to it.
pills.onPillCreate = (callback) => { pills.onPillCreate = (callback) => {
// Exercise our callback for line coverage. It is
// just compose_recipient.update_placeholder_text(),
// which we override.
callback(); callback();
}; };
pills.onPillRemove = (callback) => { pills.onPillRemove = (callback) => {
callback(); callback();
}; };
let on_pill_create_or_remove_call_count = 0;
compose_pm_pill.initialize({ compose_pm_pill.initialize({
on_pill_create_or_remove: compose_recipient.update_placeholder_text, on_pill_create_or_remove() {
on_pill_create_or_remove_call_count += 1;
},
}); });
assert.ok(compose_pm_pill.widget); assert.ok(compose_pm_pill.widget);
// Called two times via our overridden onPillCreate and onPillRemove methods.
// Normally these would be called via `set_from_typeahead` method.
assert.equal(on_pill_create_or_remove_call_count, 2);
compose_pm_pill.set_from_typeahead(othello); compose_pm_pill.set_from_typeahead(othello);
compose_pm_pill.set_from_typeahead(hamlet); compose_pm_pill.set_from_typeahead(hamlet);