Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

puppeteer: Fix incorrectly passed `false` value to check narrow change. 

This caused another CI flake.

Also, added a comment to the only other place where we pass false
explicitly explaining why.
This commit is contained in:
Aman Agrawal 2024-10-07 15:36:55 +00:00 committed by Tim Abbott
parent 1bd0ab506c
commit 777f6be88f
2 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
web/e2e-tests/compose.test.ts
View File

@ -134,15 +134,10 @@ async function test_narrow_to_private_messages_with_cordelia(page: Page): Promis
async function test_send_multirecipient_pm_from_cordelia_pm_narrow(page: Page): Promise<void> { async function test_send_multirecipient_pm_from_cordelia_pm_narrow(page: Page): Promise<void> {
const recipients = ["cordelia@zulip.com", "othello@zulip.com"]; const recipients = ["cordelia@zulip.com", "othello@zulip.com"];
const multiple_recipients_pm = "A direct message group to check spaces"; const multiple_recipients_pm = "A direct message group to check spaces";
await common.send_message( await common.send_message(page, "private", {
page, recipient: recipients.join(", "),
"private", content: multiple_recipients_pm,
{ });
recipient: recipients.join(", "),
content: multiple_recipients_pm,
},
false,
);
// Go back to the combined feed view and make sure all messages are loaded. // Go back to the combined feed view and make sure all messages are loaded.
await page.click("#left-sidebar-navigation-list .top_left_all_messages"); await page.click("#left-sidebar-navigation-list .top_left_all_messages");

1
web/e2e-tests/edit.test.ts
View File

@ -55,6 +55,7 @@ async function test_edit_message_with_slash_me(page: Page): Promise<void> {
topic: "edits", topic: "edits",
content: "/me test editing a message with me", content: "/me test editing a message with me",
}, },
// We already narrow in test_stream_message_edit.
false, false,
); );
await page.waitForSelector( await page.waitForSelector(