lint: Prohibit percent formatting on literal format strings.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-06-13 22:01:21 -07:00 · 2020-06-13 22:01:21 -07:00 · 769e198ab0
parent 5dc9b55c43
commit 769e198ab0
1 changed files with 8 additions and 0 deletions
--- a/tools/semgrep.yml
+++ b/tools/semgrep.yml
@ -116,3 +116,11 @@ rules:
              ...
    severity: ERROR
    message: "Guard mutable default with read-only type (Sequence, Mapping, AbstractSet)"
+
+  - id: percent-formatting
+    languages: [python]
+    pattern-either:
+      - pattern: '"..." % ...'
+      - pattern: '("...") % ...'
+    severity: ERROR
+    message: "Prefer f-strings or .format for string formatting"