Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

node tests: Remove stub_channel_get(). 

A few years ago I introduced the anti-pattern
of automatically calling success functions within
channel.get stubs.  It's better to just capture
the success function and call it explicitly.

Also, we now have override(), so it's easy to
inline these types of things in a safe way.
This commit is contained in:
Steve Howell 2021-03-16 11:06:21 +00:00 committed by Steve Howell
parent 6b0ceeb3b0
commit 764b83b890
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
frontend_tests/node_tests/compose_actions.js
View File

@ -62,12 +62,6 @@ const respond_to_message = compose_actions.respond_to_message;
const reply_with_mention = compose_actions.reply_with_mention;
const quote_and_reply = compose_actions.quote_and_reply;
function stub_channel_get(success_value) {
channel.get = (opts) => {
opts.success(success_value);
};
}
function assert_visible(sel) {
assert($(sel).visible());
}
@ -337,8 +331,10 @@ test("quote_and_reply", (override) => {
sender_id: 90,
};
hash_util.by_conversation_and_time_uri = () => "link_to_message";
stub_channel_get({
raw_content: "Testing.",
let success_function;
override(channel, "get", (opts) => {
success_function = opts.success;
});
current_msg_list.selected_id = () => 100;
@ -360,6 +356,10 @@ test("quote_and_reply", (override) => {
"@_**Steve Stephenson|90** [said](link_to_message):\n```quote\nTesting.\n```";
quote_and_reply(opts);
success_function({
raw_content: "Testing.",
});
assert(replaced);
selected_message = {