Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

edit_linkifier: Remove unnecessary error message display. 

We want the error message that we get on editing the
linkifier to be displayed only on the edit linkifier modal.
This commit is contained in:
akshatdalton 2021-05-12 17:26:53 +00:00 committed by Tim Abbott
parent 70f23fc422
commit 7632541afb
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
frontend_tests/puppeteer_tests/realm-linkifier.ts
View File

@ -113,11 +113,6 @@ async function test_edit_invalid_linkifier(page: Page): Promise<void> {
await page.click(".cancel-linkifier-info-change");
await page.waitForSelector("#linkifier-edit-form-modal", {hidden: true});
await page.waitForFunction(
() =>
$(".edit-linkifier-status").text().trim() ===
"Save failed: Invalid linkifier pattern. Valid characters are [ a-zA-Z_#=/:+!-].",
);
await page.waitForSelector(".linkifier_row", {visible: true});
assert.strictEqual(
await common.get_text_from_selector(page, ".linkifier_row span.linkifier_pattern"),

2
static/js/settings_linkifiers.js
View File

@ -187,6 +187,8 @@ export function build_page() {
ui_report.error($t_html({defaultMessage: "Failed"}), xhr, linkifier_status);
}
},
// Show the error message only on edit linkifier modal.
error_msg_element: $(),
};
settings_ui.do_settings_change(
channel.patch,