Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

font-awesome: Drop support for legacy font awesome icons. 

We drop support for usage of `icon-vector` as base class when
including icons from font awesome icons package.
Now on, only icons as specified in font awesome v4.7.0 can be used
in the code base.
This commit is contained in:
Aditya Bansal 2018-10-15 19:56:55 +05:30
parent 7eeed1413c
commit 75ae94e459
5 changed files with 5 additions and 1460 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/subsystems/user-docs.md
View File

@ -115,11 +115,11 @@ to be formatted correctly.
### Icons ### Icons
You can refer to features in the Zulip UI by referencing their names You can refer to features in the Zulip UI by referencing their names
and their [FontAwesome](http://fontawesome.io) (version 4.7.0) text and their [FontAwesome](https://fontawesome.com/v4.7.0/) (version 4.7.0) text
icons within parentheses. **Note:** We are migrating to the modern icons within parentheses. **Note:** We have completed migrating away from older
font awesome base class `fa` instead of the older base class base class `icon-vector` and have dropped support for it. We now only support
`icon-vector` when specifying icons. In future we will be removing icons from [FontAwesome](https://fontawesome.com/v4.7.0/) (version 4.7.0) which
support for the icons with base class `icon-vector`. make use of `fa` as a base class.
* cog (<i class="fa fa-cog"></i>) icon — `cog (<i * cog (<i class="fa fa-cog"></i>) icon — `cog (<i
class="fa fa-cog"></i>) icon` class="fa fa-cog"></i>) icon`

1
static/js/bundles/commons.js
View File

@ -14,7 +14,6 @@ import "third/bootstrap/css/bootstrap-btn.css";
import "third/bootstrap/css/bootstrap-responsive.css"; import "third/bootstrap/css/bootstrap-responsive.css";
import "node_modules/perfect-scrollbar/css/perfect-scrollbar.css"; import "node_modules/perfect-scrollbar/css/perfect-scrollbar.css";
import "node_modules/font-awesome/css/font-awesome.css"; import "node_modules/font-awesome/css/font-awesome.css";
import "third/fontawesome-legacy.css";
import "generated/icons/style.css"; import "generated/icons/style.css";
import "node_modules/source-sans-pro/source-sans-pro.css"; import "node_modules/source-sans-pro/source-sans-pro.css";
import "styles/pygments.scss"; import "styles/pygments.scss";

1452
static/third/fontawesome-legacy.css
View File

File diff suppressed because it is too large Load Diff

1
tools/linter_lib/custom_check.py
View File

@ -570,7 +570,6 @@ def build_custom_checkers(by_lang):
'bad_lines': ['background: url(https://example.com/image.png);']}, 'bad_lines': ['background: url(https://example.com/image.png);']},
{'pattern': '^[ ][ ][a-zA-Z0-9]', {'pattern': '^[ ][ ][a-zA-Z0-9]',
'description': "Incorrect 2-space indentation in CSS", 'description': "Incorrect 2-space indentation in CSS",
'exclude': set(['static/third/fontawesome-legacy.css']),
'strip': '\n', 'strip': '\n',
'good_lines': [" color: white;", "color: white;"], 'good_lines': [" color: white;", "color: white;"],
'bad_lines': [" color: white;"]}, 'bad_lines': [" color: white;"]},

1
tools/webpack.assets.json
View File

@ -48,7 +48,6 @@
"./static/third/bootstrap/css/bootstrap-responsive.css", "./static/third/bootstrap/css/bootstrap-responsive.css",
"./node_modules/perfect-scrollbar/css/perfect-scrollbar.css", "./node_modules/perfect-scrollbar/css/perfect-scrollbar.css",
"./node_modules/font-awesome/css/font-awesome.css", "./node_modules/font-awesome/css/font-awesome.css",
"./static/third/fontawesome-legacy.css",
"./static/generated/icons/style.css", "./static/generated/icons/style.css",
"./node_modules/source-sans-pro/source-sans-pro.css", "./node_modules/source-sans-pro/source-sans-pro.css",
"./static/styles/pygments.scss" "./static/styles/pygments.scss"