Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

drafts: Fix TypeScript noUncheckedIndexedAccess errors. 

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2024-05-30 10:07:58 -07:00
parent ff23f79550
commit 7303851fd5
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
web/src/drafts.ts
View File

@ -154,7 +154,7 @@ export const draft_model = (function () {
} }
function getDraft(id: string): LocalStorageDraft | false { function getDraft(id: string): LocalStorageDraft | false {
return get()[id] || false; return get()[id] ?? false;
} }
function getDraftCount(): number { function getDraftCount(): number {
@ -191,8 +191,9 @@ export const draft_model = (function () {
return _.isEqual(_.omit(draft_a, ["updatedAt"]), _.omit(draft_b, ["updatedAt"])); return _.isEqual(_.omit(draft_a, ["updatedAt"]), _.omit(draft_b, ["updatedAt"]));
} }
if (drafts[id]) { const old_draft = drafts[id];
changed = !check_if_equal(drafts[id], draft); if (old_draft !== undefined) {
changed = !check_if_equal(old_draft, draft);
drafts[id] = draft; drafts[id] = draft;
save(drafts); save(drafts);
} }
@ -264,9 +265,7 @@ export function rename_stream_recipient(
new_stream_id: number, new_stream_id: number,
new_topic: string, new_topic: string,
): void { ): void {
const current_drafts = draft_model.get(); for (const [draft_id, draft] of Object.entries(draft_model.get())) {
for (const draft_id of Object.keys(current_drafts)) {
const draft = current_drafts[draft_id];
if (draft.type !== "stream" || draft.stream_id === undefined) { if (draft.type !== "stream" || draft.stream_id === undefined) {
continue; continue;
} }
@ -655,9 +654,7 @@ export function initialize(): void {
// refreshed in the middle of sending a message. We // refreshed in the middle of sending a message. We
// reset the field on page reload to ensure that drafts // reset the field on page reload to ensure that drafts
// don't get stuck in that state. // don't get stuck in that state.
const current_drafts = draft_model.get(); for (const [draft_id, draft] of Object.entries(draft_model.get())) {
for (const draft_id of Object.keys(current_drafts)) {
const draft = current_drafts[draft_id];
if (draft.is_sending_saving) { if (draft.is_sending_saving) {
draft.is_sending_saving = false; draft.is_sending_saving = false;
draft_model.editDraft(draft_id, draft); draft_model.editDraft(draft_id, draft);