Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings: Remove obsolete message_viewport.scrollTop() calls. 

These date from long before the settings UI was restructured as an
overlay.  Now, instead of ensuring that error messages are visible,
they just scroll the message feed incorrectly.

Fixes #4810.
This commit is contained in:
Tim Abbott 2017-05-16 20:33:52 -07:00
parent 850519b314
commit 72720fcf2e
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/settings_account.js
View File

@ -11,16 +11,10 @@ exports.update_email = function (new_email) {
};
function settings_change_error(message, xhr) {
// Scroll to the top so the error message is visible.
// We would scroll anyway if we end up submitting the form.
message_viewport.scrollTop(0);
ui_report.error(message, xhr, $('#account-settings-status').expectOne());
}
function settings_change_success(message) {
// Scroll to the top so the error message is visible.
// We would scroll anyway if we end up submitting the form.
message_viewport.scrollTop(0);
ui_report.success(message, $('#account-settings-status').expectOne());
}