Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

recent_view_ui: Convert module to typescript.

This commit is contained in:
evykassirer 2024-05-03 11:53:01 -07:00 committed by Tim Abbott
parent 5aeeafd39c
commit 724306df10
4 changed files with 370 additions and 174 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/test-js-with-node
View File

@ -183,7 +183,7 @@ EXEMPT_FILES = make_set(
"web/src/realm_logo.ts", "web/src/realm_logo.ts",
"web/src/realm_playground.ts", "web/src/realm_playground.ts",
"web/src/realm_user_settings_defaults.ts", "web/src/realm_user_settings_defaults.ts",
"web/src/recent_view_ui.js", "web/src/recent_view_ui.ts",
"web/src/reload.js", "web/src/reload.js",
"web/src/reload_setup.js", "web/src/reload_setup.js",
"web/src/reminder.js", "web/src/reminder.js",

524
web/src/recent_view_ui.js → web/src/recent_view_ui.ts
View File

File diff suppressed because it is too large Load Diff

11
web/src/views_util.ts
View File

@ -1,4 +1,5 @@
import $ from "jquery"; import $ from "jquery";
import type * as tippy from "tippy.js";
import * as activity_ui from "./activity_ui"; import * as activity_ui from "./activity_ui";
import * as compose_actions from "./compose_actions"; import * as compose_actions from "./compose_actions";
@ -21,12 +22,14 @@ export const FILTERS = {
FOLLOWED_TOPICS: "followed_topics", FOLLOWED_TOPICS: "followed_topics",
}; };
const TIPPY_PROPS: Partial<tippy.Props> = {
placement: "bottom-start",
offset: [0, 2],
};
export const COMMON_DROPDOWN_WIDGET_PARAMS = { export const COMMON_DROPDOWN_WIDGET_PARAMS = {
get_options: filters_dropdown_options, get_options: filters_dropdown_options,
tippy_props: { tippy_props: TIPPY_PROPS,
placement: "bottom-start",
offset: [0, 2],
},
unique_id_type: dropdown_widget.DataTypes.STRING, unique_id_type: dropdown_widget.DataTypes.STRING,
hide_search_box: true, hide_search_box: true,
bold_current_selection: true, bold_current_selection: true,

7
web/tests/recent_view.test.js
View File

@ -479,6 +479,7 @@ test("test_recent_view_show", ({override, mock_template}) => {
$("#mark_read_on_scroll_state_banner").toggleClass = noop; $("#mark_read_on_scroll_state_banner").toggleClass = noop;
rt.clear_for_tests(); rt.clear_for_tests();
rt.set_filters_for_tests();
rt.process_messages(messages); rt.process_messages(messages);
rt.show(); rt.show();
@ -515,6 +516,7 @@ test("test_filter_is_spectator", ({mock_template}) => {
row_data = generate_topic_data([[1, "topic-1", 0, all_visibility_policies.INHERIT]]); row_data = generate_topic_data([[1, "topic-1", 0, all_visibility_policies.INHERIT]]);
i = row_data.length; i = row_data.length;
rt.clear_for_tests(); rt.clear_for_tests();
rt.set_filters_for_tests();
stub_out_filter_buttons(); stub_out_filter_buttons();
recent_view_util.set_visible(true); recent_view_util.set_visible(true);
rt.process_messages([messages[0]]); rt.process_messages([messages[0]]);
@ -549,6 +551,7 @@ test("test_no_filter", ({mock_template}) => {
row_data = generate_topic_data([[1, "topic-1", 0, all_visibility_policies.INHERIT]]); row_data = generate_topic_data([[1, "topic-1", 0, all_visibility_policies.INHERIT]]);
i = row_data.length; i = row_data.length;
rt.clear_for_tests(); rt.clear_for_tests();
rt.set_filters_for_tests();
stub_out_filter_buttons(); stub_out_filter_buttons();
recent_view_util.set_visible(true); recent_view_util.set_visible(true);
rt.process_messages([messages[0]]); rt.process_messages([messages[0]]);
@ -676,6 +679,7 @@ test("test_filter_pm", ({mock_template}) => {
}); });
rt.clear_for_tests(); rt.clear_for_tests();
rt.set_filters_for_tests();
stub_out_filter_buttons(); stub_out_filter_buttons();
recent_view_util.set_visible(true); recent_view_util.set_visible(true);
rt.set_filter("include_private"); rt.set_filter("include_private");
@ -737,6 +741,7 @@ test("test_filter_participated", ({mock_template}) => {
}); });
rt.clear_for_tests(); rt.clear_for_tests();
rt.set_filters_for_tests();
recent_view_util.set_visible(true); recent_view_util.set_visible(true);
rt.set_default_focus(); rt.set_default_focus();
stub_out_filter_buttons(); stub_out_filter_buttons();
@ -828,6 +833,7 @@ test("test_update_unread_count", () => {
test("basic assertions", ({mock_template, override_rewire}) => { test("basic assertions", ({mock_template, override_rewire}) => {
override_rewire(rt, "inplace_rerender", noop); override_rewire(rt, "inplace_rerender", noop);
rt.clear_for_tests(); rt.clear_for_tests();
rt.set_filters_for_tests();
mock_template("recent_view_table.hbs", false, noop); mock_template("recent_view_table.hbs", false, noop);
mock_template("recent_view_row.hbs", true, (_data, html) => { mock_template("recent_view_row.hbs", true, (_data, html) => {
@ -962,6 +968,7 @@ test("test_reify_local_echo_message", ({mock_template}) => {
mock_template("recent_view_row.hbs", false, noop); mock_template("recent_view_row.hbs", false, noop);
rt.clear_for_tests(); rt.clear_for_tests();
rt.set_filters_for_tests();
stub_out_filter_buttons(); stub_out_filter_buttons();
recent_view_util.set_visible(true); recent_view_util.set_visible(true);
rt.process_messages(messages); rt.process_messages(messages);