Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

user profile: Fix height issues with remove-subscription-button. 

Previously, subscription rows with a remove-subscription-button were
much taller than those without. This will be problematic when the new
permissions setting makes it possible for the current user to have
permission to unsubscribe the target user from some streams but not
others.

Fix this by both making the button a bit less tall and setting a
minimum height for the rows. Probably a nicer CSS solution is
possible, but this is enough to unblock merging a much larger project.
This commit is contained in:
Tim Abbott 2023-02-05 12:33:31 -08:00
parent 8bd881c83f
commit 6fa0a83d6b
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
static/styles/popovers.css
View File

@ -514,6 +514,11 @@ ul {
margin-bottom: 5px;
-webkit-overflow-scrolling: touch;
.remove-subscription-button {
padding-top: 2px;
padding-bottom: 2px;
}
.user-stream-list,
.user-group-list {
width: 100%;
@ -522,6 +527,9 @@ ul {
tr {
border-bottom: 1px solid hsl(0, 0%, 87%);
/* Ensure equal height for rows with a remove-subscription-button and
those without one. */
height: 34px;
&:last-of-type {
border-bottom: none;