js: Add "use strict" directive to CommonJS files.

ES and TypeScript modules are strict by default and don’t need this
directive.  ESLint will remind us to add it to new CommonJS files and
remove it from ES and TypeScript modules.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

.eslintrc.json

@@ -7,7 +7,7 @@
     "parser": "babel-eslint",
     "parserOptions": {
         "warnOnUnsupportedTypeScriptVersion": false,
-        "sourceType": "module"
+        "sourceType": "unambiguous"
     },
     "plugins": ["eslint-plugin-empty-returns"],
     "rules": {
@@ -29,6 +29,7 @@
                 "newlines-between": "always"
             }
         ],
+        "import/unambiguous": "error",
         "new-cap": [
             "error",
             {
@@ -88,7 +89,7 @@
         ],
         "radix": "error",
         "spaced-comment": "off",
-        "strict": "off",
+        "strict": "error",
         "valid-typeof": ["error", {"requireStringLiterals": true}],
         "yoda": "error"
     },
@@ -331,6 +332,12 @@
                 "@typescript-eslint/unified-signatures": "error"
             }
         },
+        {
+            "files": ["**/*.d.ts"],
+            "rules": {
+                "import/unambiguous": "off"
+            }
+        },
         {
             "files": ["frontend_tests/**"],
             "globals": {

babel.config.js

@@ -1,3 +1,5 @@
+"use strict";
+
 module.exports = {
     presets: [
         [

frontend_tests/casper_lib/common.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var util = require("util");
 
 var test_credentials = require("../../var/casper/test_credentials.js").test_credentials;

frontend_tests/casper_lib/polyfill.js

@@ -1,3 +1,5 @@
+"use strict";
+
 /* eslint-env browser */
 
 // PhantomJS doesn’t support new DOMParser().parseFromString(…, "text/html").

frontend_tests/casper_tests/00-realm-creation.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 var email = "alice@test.example.com";

frontend_tests/casper_tests/01-login.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 var realm_url = "http://zulip.zulipdev.com:9981/";

frontend_tests/casper_tests/02-site.js

@@ -1,3 +1,5 @@
+"use strict";
+
 /* Script for testing the web client.
 
    This runs under CasperJS.  It's an end-to-end black-box sort of test.  It

frontend_tests/casper_tests/03-narrow.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

frontend_tests/casper_tests/04-compose.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

frontend_tests/casper_tests/05-subscriptions.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 function stream_checkbox(stream_name) {

frontend_tests/casper_tests/06-settings.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var test_credentials = require("../../var/casper/test_credentials.js").test_credentials;
 var common = require("../casper_lib/common.js");
 

frontend_tests/casper_tests/07-stars.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 function star_count() {

frontend_tests/casper_tests/08-edit.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 casper.options.verbose = true;

frontend_tests/casper_tests/09-navigation.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 // Test basic tab navigation.

frontend_tests/casper_tests/10-admin.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

frontend_tests/casper_tests/11-mention.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

frontend_tests/casper_tests/12-custom-profile.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

frontend_tests/casper_tests/13-user-deactivation.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 function user_row(name) {

frontend_tests/casper_tests/14-drafts.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 function waitWhileDraftsVisible(then) {

frontend_tests/casper_tests/15-delete-message.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

frontend_tests/casper_tests/16-copy-and-paste.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

frontend_tests/casper_tests/17-realm-linkifier.js

@@ -1,3 +1,5 @@
+"use strict";
+
 var common = require("../casper_lib/common.js");
 
 common.start_and_log_in();

frontend_tests/node_tests/activity.js

@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 const window_stub = $.create("window-stub");
 set_global("to_$", () => window_stub);

frontend_tests/node_tests/alert_words.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const params = {
     alert_words: ["alertone", "alerttwo", "alertthree", "al*rt.*s", ".+", "emoji"],
 };

frontend_tests/node_tests/alert_words_ui.js

@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 
 set_global("channel", {});

frontend_tests/node_tests/billing.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const noop = () => {};
 const fs = require("fs");
 

frontend_tests/node_tests/billing_helpers.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const fs = require("fs");
 
 const JQuery = require("jquery");

frontend_tests/node_tests/blueslip_stacktrace.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const blueslip_stacktrace = zrequire("blueslip_stacktrace");
 
 run_test("clean_path", () => {

frontend_tests/node_tests/bot_data.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const _settings_bots = {
     render_bots: () => {},
 };

frontend_tests/node_tests/buddy_data.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const _ = require("lodash");
 
 const _page_params = {};

frontend_tests/node_tests/buddy_list.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const _ = require("lodash");
 
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/channel.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const _ = require("lodash");
 
 set_global("$", {});

frontend_tests/node_tests/color_data.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("color_data");
 
 run_test("pick_color", () => {

frontend_tests/node_tests/colorspace.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("colorspace");
 
 run_test("sRGB_to_linear", () => {

frontend_tests/node_tests/common.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const noop = () => {};
 
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/components.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const _ = require("lodash");
 
 zrequire("keydown_util");

frontend_tests/node_tests/compose.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const {JSDOM} = require("jsdom");
 const rewiremock = require("rewiremock/node");
 

frontend_tests/node_tests/compose_actions.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const noop = function () {};
 const return_false = function () {
     return false;

frontend_tests/node_tests/compose_fade.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("stream_data");
 zrequire("people");
 zrequire("compose_fade");

frontend_tests/node_tests/compose_pm_pill.js

@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 
 const _people = {

frontend_tests/node_tests/compose_ui.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("compose_ui");
 zrequire("people");
 zrequire("user_status");

frontend_tests/node_tests/composebox_typeahead.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const emoji = zrequire("emoji", "shared/js/emoji");
 const typeahead = zrequire("typeahead", "shared/js/typeahead");
 zrequire("compose_state");

frontend_tests/node_tests/copy_and_paste.js

@@ -1,3 +1,5 @@
+"use strict";
+
 global.stub_out_jquery();
 
 set_global("page_params", {

frontend_tests/node_tests/dispatch.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const noop = function () {};
 
 const events = require("./lib/events.js");

frontend_tests/node_tests/dispatch_subs.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const events = require("./lib/events.js");
 
 const event_fixtures = events.fixtures;

frontend_tests/node_tests/drafts.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const XDate = require("xdate");
 
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/dropdown_list_widget.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("dropdown_list_widget");
 zrequire("scroll_util");
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/echo.js

@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 set_global("markdown", {});
 set_global("local_message", {

frontend_tests/node_tests/emoji.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const emoji_codes = zrequire("emoji_codes", "generated/emoji/emoji_codes.json");
 
 const events = require("./lib/events.js");

frontend_tests/node_tests/emoji_picker.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const _ = require("lodash");
 
 const emoji = zrequire("emoji", "shared/js/emoji");

frontend_tests/node_tests/fenced_code.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const fenced_code = zrequire("fenced_code", "shared/js/fenced_code");
 
 run_test("get_unused_fence", () => {

frontend_tests/node_tests/fetch_status.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const FetchStatus = zrequire("fetch_status");
 set_global("message_scroll", {
     hide_loading_older: () => {},

frontend_tests/node_tests/filter.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("unread");
 zrequire("stream_data");
 zrequire("people");

frontend_tests/node_tests/fold_dict.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const FoldDict = zrequire("fold_dict").FoldDict;
 
 run_test("basic", () => {

frontend_tests/node_tests/general.js

@@ -1,3 +1,5 @@
+"use strict";
+
 // This is a general tour of how to write node tests that
 // may also give you some quick insight on how the Zulip
 // browser app is constructed.  Let's start with testing

frontend_tests/node_tests/hash_util.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("hash_util");
 zrequire("stream_data");
 zrequire("people");

frontend_tests/node_tests/hashchange.js

@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 const window_stub = $.create("window-stub");
 set_global("location", {

frontend_tests/node_tests/hotkey.js

@@ -1,3 +1,5 @@
+"use strict";
+
 // Important note on these tests:
 //
 // The way the Zulip hotkey tests work is as follows.  First, we set

frontend_tests/node_tests/i18n.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("templates");
 
 // We download our translations in `page_params` (which

frontend_tests/node_tests/input_pill.js

@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 zrequire("input_pill");
 

frontend_tests/node_tests/keydown_util.js

@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 
 zrequire("keydown_util");

frontend_tests/node_tests/lazy_set.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const LazySet = zrequire("lazy_set").LazySet;
 
 /*

frontend_tests/node_tests/lib/events.js

@@ -1,3 +1,5 @@
+"use strict";
+
 // TODO: These events are not guaranteed to be perfectly
 //       representative of what the server sends.  For
 //       now we just want very basic test coverage.  We

frontend_tests/node_tests/lightbox.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("rows");
 zrequire("lightbox");
 

frontend_tests/node_tests/list_cursor.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("list_cursor");
 
 run_test("config errors", () => {

frontend_tests/node_tests/list_render.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("list_render");
 
 // We need these stubs to get by instanceof checks.

frontend_tests/node_tests/markdown.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("hash_util");
 
 const emoji = zrequire("emoji", "shared/js/emoji");

frontend_tests/node_tests/markdown_katex.js

@@ -1,3 +1,5 @@
+"use strict";
+
 /*
     This whole module is dedicated to adding
     one line of coverage for markdown.js.

frontend_tests/node_tests/message_edit.js

@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("document", null);
 set_global("page_params", {
     realm_community_topic_editing_limit_seconds: 86400,

frontend_tests/node_tests/message_events.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("message_events");
 zrequire("message_store");
 zrequire("muting");

frontend_tests/node_tests/message_fetch.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const _ = require("lodash");
 
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/message_flags.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("unread");
 zrequire("unread_ops");
 zrequire("message_flags");

frontend_tests/node_tests/message_list.js

@@ -1,3 +1,5 @@
+"use strict";
+
 // These unit tests for static/js/message_list.js emphasize the model-ish
 // aspects of the MessageList class.  We have to stub out a few functions
 // related to views and events to get the tests working.

frontend_tests/node_tests/message_list_data.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("unread");
 
 zrequire("Filter", "js/filter");

frontend_tests/node_tests/message_list_view.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const _ = require("lodash");
 
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/message_store.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const util = zrequire("util");
 zrequire("pm_conversations");
 zrequire("people");

frontend_tests/node_tests/muting.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("timerender");
 zrequire("muting");
 zrequire("stream_data");

frontend_tests/node_tests/narrow.js

@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 zrequire("hash_util");
 zrequire("hashchange");

frontend_tests/node_tests/narrow_activate.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const util = zrequire("util");
 set_global("$", global.make_zjquery());
 

frontend_tests/node_tests/narrow_local.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("Filter", "js/filter");
 zrequire("FetchStatus", "js/fetch_status");
 zrequire("MessageListData", "js/message_list_data");

frontend_tests/node_tests/narrow_state.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("people");
 zrequire("Filter", "js/filter");
 zrequire("stream_data");

frontend_tests/node_tests/narrow_unread.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("Filter", "js/filter");
 zrequire("people");
 zrequire("stream_data");

frontend_tests/node_tests/notifications.js

@@ -1,3 +1,5 @@
+"use strict";
+
 // Dependencies
 set_global(
     "$",

frontend_tests/node_tests/password.js

@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("zxcvbn", zrequire("zxcvbn", "zxcvbn"));
 zrequire("common");
 

frontend_tests/node_tests/people.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const _ = require("lodash");
 const moment = require("moment-timezone");
 const rewiremock = require("rewiremock/node");

frontend_tests/node_tests/people_errors.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("people");
 
 const return_false = function () {

frontend_tests/node_tests/pm_conversations.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const pmc = zrequire("pm_conversations");
 
 run_test("partners", () => {

frontend_tests/node_tests/pm_list.js

@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("$", global.make_zjquery());
 
 set_global("narrow_state", {});

frontend_tests/node_tests/poll_widget.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("poll_widget");
 
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/popovers.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const rewiremock = require("rewiremock/node");
 
 set_global("$", global.make_zjquery());

frontend_tests/node_tests/presence.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const XDate = require("xdate");
 
 zrequire("people");

frontend_tests/node_tests/reactions.js

@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("document", "document-stub");
 set_global("$", global.make_zjquery());
 

frontend_tests/node_tests/recent_senders.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const rs = zrequire("recent_senders");
 
 let next_id = 0;

frontend_tests/node_tests/recent_topics.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("message_util");
 
 const noop = () => {};

frontend_tests/node_tests/rendered_markdown.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const rm = zrequire("rendered_markdown");
 zrequire("people");
 zrequire("user_groups");

frontend_tests/node_tests/rtl.js

@@ -1,3 +1,5 @@
+"use strict";
+
 const rtl = zrequire("rtl");
 
 run_test("get_direction", () => {

frontend_tests/node_tests/schema.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("schema");
 
 run_test("basics", () => {

frontend_tests/node_tests/scroll_util.js

@@ -1,3 +1,5 @@
+"use strict";
+
 zrequire("scroll_util");
 set_global("ui", {
     get_scroll_element: (element) => element,

frontend_tests/node_tests/search.js

@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("page_params", {
     search_pills_enabled: true,
 });

frontend_tests/node_tests/search_legacy.js

@@ -1,3 +1,5 @@
+"use strict";
+
 set_global("page_params", {
     search_pills_enabled: false,
 });