Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Simplify condition for aborting people.reify(). 

Since it's basically impossible to add a person with an
undefined full_name--even "skeleton" people--there is no
need to check the full_name field to short circuit reify(),
because it will always be defined.

(imported from commit 3a30cfd583a040f7460739abea1604594c450ffe)
This commit is contained in:
Steve Howell 2014-03-12 15:15:16 -04:00 committed by Leo Franchi
parent cbb5878477
commit 6ec72a290d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/people.js
View File

@ -89,9 +89,9 @@ exports.reify = function reify(person) {
var old_person = people_dict.get(person.email); var old_person = people_dict.get(person.email);
// Don't overwrite an already-reified person. If we have // Only overwrite skeleton objects here. If the object
// a full name, we already have the full person object loaded // had already been reified, exit early.
if (old_person.full_name !== undefined && !old_person.skeleton) { if (!old_person.skeleton) {
return; return;
} }