From 6dc12295db9f2481dc0f5af203a857222940d12b Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Sat, 18 Apr 2020 16:15:20 -0700 Subject: [PATCH] test_alert_words: Fix broken accidentally working test. This test was passing a string, not an Iterable[str], and effectively a quirk in the remove_alert_words implementation happened to result in processing each character in the string working. --- zerver/tests/test_alert_words.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zerver/tests/test_alert_words.py b/zerver/tests/test_alert_words.py index b2981d7c6a..5e85413a00 100644 --- a/zerver/tests/test_alert_words.py +++ b/zerver/tests/test_alert_words.py @@ -67,7 +67,7 @@ class AlertWordTests(ZulipTestCase): add_user_alert_words(user, self.interesting_alert_word_list) for alert_word in self.interesting_alert_word_list: - remove_user_alert_words(user, alert_word) + remove_user_alert_words(user, [alert_word]) expected_remaining_alerts.remove(alert_word) actual_remaining_alerts = user_alert_words(user) self.assertEqual(set(actual_remaining_alerts),