Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

narrow: Fix narrowing behavior when loading a new tab. 

In the very early days of Zulip, we didn't have unread counts; just
the pointer, and the correct behavior when opening a new tab was to
place you near the pointer.  That doesn't make any sense now that we
do have unread counts, and this corner case has been a wart for a long
time.

This commit does the main behavior change here.  However, there's a
bug we need to fix, where we might end up trying to pre-render a view
of the narrow based on the `all_msg_list` data before `all_msg_list`
is caught up).  We need to fix that bug before we can merge this; it
should be possible to determine that using `FetchStatus` on
`all_msg_list`, or with better performance by using the `unread_msgs`
structure to determine whether the message we should be selecting is
present locally.

Fixes #789.
Fixes #9070.
This commit is contained in:
Tim Abbott 2018-04-18 17:13:44 -07:00
parent 1d5204c82b
commit 6bab4e0aad
2 changed files with 1 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
docs/subsystems/pointer.md
View File

@ -36,7 +36,7 @@ what you clicked on, and in fact the message you clicked on stays at
exactly the same scroll position in the window after the narrowing as exactly the same scroll position in the window after the narrowing as
it was at before. it was at before.
### Search or sidebar click: unread/recent matching narrow ### Search, sidebar click, or new narrowed tab: unread/recent matching narrow
If you instead narrow by clicking on something in the left sidebar or If you instead narrow by clicking on something in the left sidebar or
typing some terms into the search box, Zulip will instead select typing some terms into the search box, Zulip will instead select
@ -71,16 +71,6 @@ streams in your All messages view, this can lag.
We plan to change this to automatically advance the pointer in a way We plan to change this to automatically advance the pointer in a way
similar to the unnarrow logic. similar to the unnarrow logic.
### Narrow in a new tab: closest to pointer
When you load a new browser tab or window to a narrowed view, Zulip
will select the message closest to your pointer, which is what you
would have got had you loaded the browser window to your All messages view and
then clicked on the nearest message matching your narrow (which might
have been offscreen).
We plan to change this to match the Search/sidebar behavior.
### Forced reload: state preservation ### Forced reload: state preservation
When the server forces a reload of a browser that's otherwise caught When the server forces a reload of a browser that's otherwise caught

10
static/js/narrow.js
View File

@ -101,16 +101,6 @@ exports.activate = function (raw_operators, opts) {
opts.select_first_unread = false; opts.select_first_unread = false;
} }
// This block is for a case of loading a browser window for the
// first time in a narrow.
// According to old comments, this shouldn't happen anymore;
// more investigation is needed.
if (opts.then_select_id === -1 && !opts.use_initial_narrow_pointer) {
blueslip.warn("Setting then_select_id to page_params.pointer.");
opts.then_select_id = page_params.pointer;
opts.select_first_unread = false;
}
var then_select_id = opts.then_select_id; var then_select_id = opts.then_select_id;
var then_select_offset; var then_select_offset;