Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

timerender: Fix should_display_profile_incomplete_alert. 

new Date requires timestamps in milliseconds.
This commit is contained in:
Tim Abbott 2024-07-09 16:03:54 -07:00
parent c9af4d571b
commit 6b5847dbf7
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/timerender.ts
View File

@ -536,7 +536,7 @@ export function get_time_limit_setting_in_appropriate_unit(
export function should_display_profile_incomplete_alert(timestamp: number): boolean { export function should_display_profile_incomplete_alert(timestamp: number): boolean {
const today = new Date(Date.now()); const today = new Date(Date.now());
const time = new Date(timestamp); const time = new Date(timestamp * 1000);
const days_old = difference_in_calendar_days(today, time, display_time_zone); const days_old = difference_in_calendar_days(today, time, display_time_zone);
if (days_old >= 15) { if (days_old >= 15) {

14
web/tests/timerender.test.js
View File

@ -631,14 +631,14 @@ run_test("set_full_datetime", () => {
run_test("should_display_profile_incomplete_alert", () => { run_test("should_display_profile_incomplete_alert", () => {
// Organization created < 15 days ago // Organization created < 15 days ago
let realm_date_created = new Date(); let realm_date_created_secs = Date.now() / 1000;
realm_date_created.setDate(realm_date_created.getDate() - 5); assert.equal(
timerender.should_display_profile_incomplete_alert(realm_date_created_secs),
assert.equal(timerender.should_display_profile_incomplete_alert(realm_date_created), false); false,
);
// Organization created > 15 days ago // Organization created > 15 days ago
realm_date_created = new Date(); realm_date_created_secs -= 16 * 86400;
realm_date_created.setDate(realm_date_created.getDate() - 15);
assert.equal(timerender.should_display_profile_incomplete_alert(realm_date_created), true); assert.equal(timerender.should_display_profile_incomplete_alert(realm_date_created_secs), true);
}); });