Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

narrow-banner: Update default empty banner text to be more general. 

Updates the default empty narrow banner text to be more generally
applicable, particularly in the case when all messages have been
moved to a new topic.
This commit is contained in:
Lauryn Menard 2022-12-08 12:35:49 +01:00 committed by Tim Abbott
parent 6759767b14
commit 6b3fbab520
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
frontend_tests/node_tests/narrow.js
View File

@ -214,7 +214,7 @@ run_test("show_empty_narrow_message", ({mock_template}) => {
assert.equal( assert.equal(
$(".empty_feed_notice_main").html(), $(".empty_feed_notice_main").html(),
empty_narrow_html( empty_narrow_html(
"translated: Nothing's been sent here yet!", "translated: There are no messages here.",
'translated HTML: Why not <a href="#" class="empty_feed_compose_stream">start the conversation</a>?', 'translated HTML: Why not <a href="#" class="empty_feed_compose_stream">start the conversation</a>?',
), ),
); );
@ -278,7 +278,7 @@ run_test("show_empty_narrow_message", ({mock_template}) => {
narrow_banner.show_empty_narrow_message(); narrow_banner.show_empty_narrow_message();
assert.equal( assert.equal(
$(".empty_feed_notice_main").html(), $(".empty_feed_notice_main").html(),
empty_narrow_html("translated: Nothing's been sent here yet!", ""), empty_narrow_html("translated: There are no messages here.", ""),
); );
page_params.is_spectator = false; page_params.is_spectator = false;
@ -517,7 +517,7 @@ run_test("show_empty_narrow_message", ({mock_template}) => {
assert.equal( assert.equal(
$(".empty_feed_notice_main").html(), $(".empty_feed_notice_main").html(),
empty_narrow_html( empty_narrow_html(
"translated: Nothing's been sent here yet!", "translated: There are no messages here.",
'translated HTML: Why not <a href="#" class="empty_feed_compose_stream">start the conversation</a>?', 'translated HTML: Why not <a href="#" class="empty_feed_compose_stream">start the conversation</a>?',
), ),
); );
@ -528,7 +528,7 @@ run_test("show_empty_narrow_message", ({mock_template}) => {
assert.equal( assert.equal(
$(".empty_feed_notice_main").html(), $(".empty_feed_notice_main").html(),
empty_narrow_html( empty_narrow_html(
"translated: Nothing's been sent here yet!", "translated: There are no messages here.",
'translated HTML: Why not <a href="#" class="empty_feed_compose_stream">start the conversation</a>?', 'translated HTML: Why not <a href="#" class="empty_feed_compose_stream">start the conversation</a>?',
), ),
); );
@ -546,7 +546,7 @@ run_test("show_empty_narrow_message", ({mock_template}) => {
assert.equal( assert.equal(
$(".empty_feed_notice_main").html(), $(".empty_feed_notice_main").html(),
empty_narrow_html( empty_narrow_html(
"translated: Nothing's been sent here yet!", "translated: There are no messages here.",
'translated HTML: Why not <a href="#" class="empty_feed_compose_stream">start the conversation</a>?', 'translated HTML: Why not <a href="#" class="empty_feed_compose_stream">start the conversation</a>?',
), ),
); );

2
static/js/narrow_banner.js
View File

@ -66,7 +66,7 @@ function retrieve_search_query_data() {
function pick_empty_narrow_banner() { function pick_empty_narrow_banner() {
const default_banner = { const default_banner = {
title: $t({defaultMessage: "Nothing's been sent here yet!"}), title: $t({defaultMessage: "There are no messages here."}),
// Spectators cannot start a conversation. // Spectators cannot start a conversation.
html: page_params.is_spectator html: page_params.is_spectator
? "" ? ""