Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor: Use precise names for migration helpers. 

Somewhat confusingly, we have two types of different
digests related to databases.  The migration digests
are pragmatic, since changes to migrations are a bit
more frequent for certain use cases and don't
necessitate a complete rebuild of the database.

Anyway, these are just more specific names.
This commit is contained in:
Steve Howell 2020-04-22 09:51:06 +00:00 committed by Tim Abbott
parent dad4ba3cd1
commit 67d0349239
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/lib/test_fixtures.py
View File

@ -155,7 +155,7 @@ class Database:
# changes, we can safely assume we don't need to run
# migrations without spending a few 100ms parsing all the
# Python migration code.
if not self.is_digest_obsolete():
if not self.is_migration_digest_obsolete():
return 'current'
'''
@ -167,7 +167,7 @@ class Database:
AFTER the migrations actually succeeded, but the
caller codepaths are kind of complicated here.
'''
self.write_new_digest()
self.write_new_migration_digest()
migration_op = self.what_to_do_with_migrations()
if migration_op == 'scrap':
@ -178,13 +178,13 @@ class Database:
return 'current'
def is_digest_obsolete(self) -> bool:
def is_migration_digest_obsolete(self) -> bool:
return is_digest_obsolete(
self.migration_digest_file,
migration_paths(),
)
def write_new_digest(self) -> None:
def write_new_migration_digest(self) -> None:
write_new_digest(
self.migration_digest_file,
migration_paths(),