From 638eb7a8e4381d4ef91127ed44406f6fb0a4b3eb Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Thu, 16 Nov 2017 10:54:24 -0800 Subject: [PATCH] docs: Update links to ReadTheDocs to always use https. This is better security practice. We also add a lint rule to enforce this for the future. --- CONTRIBUTING.md | 22 ++++++++--------- README.md | 2 +- static/js/pointer.js | 2 +- .../subscription_creation_form.handlebars | 2 +- templates/zerver/accounts_home.html | 2 +- templates/zerver/config_error.html | 4 ++-- templates/zerver/for/open-source.md | 2 +- .../zerver/help/enable-high-contrast-mode.md | 2 +- ...ng-your-organization-started-with-zulip.md | 4 ++-- .../zerver/help/include/running-a-bot.md | 2 +- templates/zerver/history.html | 4 ++-- templates/zerver/integrations/index.html | 2 +- tools/README.md | 2 +- tools/check-frontend-i18n | 24 +++++++++---------- tools/droplets/README.md | 4 ++-- tools/droplets/create.py | 6 ++--- tools/lib/provision.py | 2 +- tools/linter_lib/custom_check.py | 3 +++ zerver/fixtures/config.generate_data.json | 14 +++++------ zerver/tests/test_events.py | 2 +- zerver/worker/queue_processors.py | 2 +- 21 files changed, 56 insertions(+), 53 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a235e07dd6..84e7edd29b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,9 +9,9 @@ The is the primary communication forum for the Zulip community. It is a good place to start whether you have a question, are a new contributor, are a new user, or anything else. Make sure to read the -[community norms](http://zulip.readthedocs.io/en/latest/contributing/chat-zulip-org.html#community-norms) +[community norms](https://zulip.readthedocs.io/en/latest/contributing/chat-zulip-org.html#community-norms) before posting. The Zulip community is also governed by a -[code of conduct](http://zulip.readthedocs.io/en/latest/code-of-conduct.html). +[code of conduct](https://zulip.readthedocs.io/en/latest/code-of-conduct.html). You can subscribe to zulip-devel@googlegroups.com for a lower traffic (~1 email/month) way to hear about things like mentorship opportunities with Google @@ -31,10 +31,10 @@ needs doing: [desktop app](https://github.com/zulip/zulip-electron). * Building out our [Python API and bots](https://github.com/zulip/python-zulip-api) framework. -* [Writing an integration](http://zulip.readthedocs.io/en/latest/tutorials/integration-guide.html). +* [Writing an integration](https://zulip.readthedocs.io/en/latest/tutorials/integration-guide.html). * Improving our [user](https://chat.zulip.org/help/) or [developer](https://zulip.readthedocs.io/en/latest/) documentation. -* [Reviewing code](http://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html) +* [Reviewing code](https://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html) and manually testing pull requests. **Non-code contributions**: Some of the most valuable ways to contribute @@ -55,7 +55,7 @@ contributor. It's long, but don't worry about doing all the steps perfectly; no one gets it right the first time, and there are a lot of people available to help. * First, make an account on the - [Zulip community server](http://zulip.readthedocs.io/en/latest/contributing/chat-zulip-org.html), + [Zulip community server](https://zulip.readthedocs.io/en/latest/contributing/chat-zulip-org.html), paying special attention to the community norms. If you'd like, introduce yourself in [#new members](https://chat.zulip.org/#narrow/stream/new.20members), using @@ -68,7 +68,7 @@ to help. [#development help](https://chat.zulip.org/#narrow/stream/development.20help) if you run into any troubles. * Read the - [Zulip guide to Git](http://zulip.readthedocs.io/en/latest/contributing/git-guide.html) + [Zulip guide to Git](https://zulip.readthedocs.io/en/latest/contributing/git-guide.html) and do the Git tutorial (coming soon) if you are unfamiliar with Git, getting help in [#git help](https://chat.zulip.org/#narrow/stream/git.20help) if you run @@ -162,14 +162,14 @@ best predictors of success: understanding, saying what you've done or tried so far, and including tracebacks or other error messages if appropriate. * Learning and practicing - [Git commit discipline](http://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-discipline). + [Git commit discipline](https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-discipline). * Submitting carefully tested code. This generally means checking your work through a combination of automated tests and manually clicking around the UI trying to find bugs in your work. See - [things to look for](http://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html#things-to-look-for) + [things to look for](https://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html#things-to-look-for) for additional ideas. * Posting - [screenshots or GIFs](http://zulip.readthedocs.io/en/latest/tutorials/screenshot-and-gif-software.html) + [screenshots or GIFs](https://zulip.readthedocs.io/en/latest/tutorials/screenshot-and-gif-software.html) for frontend changes. * Being responsive to feedback on pull requests. This means incorporating or responding to all suggested changes, and leaving a note if you won't be @@ -189,12 +189,12 @@ is, the best place to post issues is [#issues](https://chat.zulip.org/#narrow/stream/issues) (or [#mobile](https://chat.zulip.org/#narrow/stream/mobile) or [#electron](https://chat.zulip.org/#narrow/stream/electron)) on the -[Zulip community server](http://zulip.readthedocs.io/en/latest/contributing/chat-zulip-org.html). +[Zulip community server](https://zulip.readthedocs.io/en/latest/contributing/chat-zulip-org.html). This allows us to interactively figure out what is going on, let you know if a similar issue has already been opened, and collect any other information we need. Choose a 2-4 word topic that describes the issue, explain the issue and how to reproduce it if known, your browser/OS if relevant, and a -[screenshot or screenGIF](http://zulip.readthedocs.io/en/latest/tutorials/screenshot-and-gif-software.html) +[screenshot or screenGIF](https://zulip.readthedocs.io/en/latest/tutorials/screenshot-and-gif-software.html) if appropriate. **Reporting security issues**. Please do not report security issues diff --git a/README.md b/README.md index 8e95880fff..7375a02865 100644 --- a/README.md +++ b/README.md @@ -11,7 +11,7 @@ largest and fastest growing open source group chat project. [![Build Status](https://travis-ci.org/zulip/zulip.svg?branch=master)](https://travis-ci.org/zulip/zulip) [![Coverage Status](https://img.shields.io/codecov/c/github/zulip/zulip.svg)](https://codecov.io/gh/zulip/zulip) [![Mypy coverage](https://img.shields.io/badge/mypy-100%25-green.svg)](http://blog.zulip.org/2016/10/13/static-types-in-python-oh-mypy/) -[![docs](https://readthedocs.org/projects/zulip/badge/?version=latest)](http://zulip.readthedocs.io/en/latest/) +[![docs](https://readthedocs.org/projects/zulip/badge/?version=latest)](https://zulip.readthedocs.io/en/latest/) [![Zulip chat](https://img.shields.io/badge/zulip-join_chat-brightgreen.svg)](https://chat.zulip.org) [![Twitter](https://img.shields.io/badge/twitter-@zulip-blue.svg?style=flat)](http://twitter.com/zulip) diff --git a/static/js/pointer.js b/static/js/pointer.js index 7fabcddbb4..f47c4d0ae5 100644 --- a/static/js/pointer.js +++ b/static/js/pointer.js @@ -1,4 +1,4 @@ -// See http://zulip.readthedocs.io/en/latest/subsystems/pointer.html for notes on +// See https://zulip.readthedocs.io/en/latest/subsystems/pointer.html for notes on // how this system is designed. var pointer = (function () { diff --git a/static/templates/subscription_creation_form.handlebars b/static/templates/subscription_creation_form.handlebars index 8fc53ee5af..a0c1f0a6c7 100644 --- a/static/templates/subscription_creation_form.handlebars +++ b/static/templates/subscription_creation_form.handlebars @@ -24,7 +24,7 @@
{{#tr this}} - For more information on public/private streams, check out our docs. + For more information on public/private streams, check out our docs. {{/tr}}