Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

bot_owner_id: Explicitly set bot_owner_id to None. 

For cross realm bots, explicitly set bot_owner_id
to None.  This makes it clear that the cross realm
bots have no owner, whereas before it could be
misdiagnosed as the server forgetting to set the
field.
This commit is contained in:
Steve Howell 2020-01-07 12:58:58 +00:00 committed by Tim Abbott
parent 96a50422f7
commit 630aadb7e0
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
zerver/lib/actions.py
View File

@ -4980,6 +4980,7 @@ def get_cross_realm_dicts() -> List[Dict[str, Any]]:
'avatar_url': avatar_url(user),
'timezone': user.timezone,
'date_joined': user.date_joined.isoformat(),
'bot_owner_id': None,
'full_name': user.full_name}
for user in users
# Important: We filter here, is addition to in

4
zerver/tests/test_home.py
View File

@ -584,6 +584,7 @@ class HomeTest(ZulipTestCase):
is_admin=False,
email='emailgateway@zulip.com',
full_name='Email Gateway',
bot_owner_id=None,
is_bot=True
),
dict(
@ -591,6 +592,7 @@ class HomeTest(ZulipTestCase):
is_admin=False,
email='feedback@zulip.com',
full_name='Zulip Feedback Bot',
bot_owner_id=None,
is_bot=True
),
dict(
@ -598,6 +600,7 @@ class HomeTest(ZulipTestCase):
is_admin=False,
email=notification_bot.email,
full_name='Notification Bot',
bot_owner_id=None,
is_bot=True
),
dict(
@ -605,6 +608,7 @@ class HomeTest(ZulipTestCase):
is_admin=False,
email='welcome-bot@zulip.com',
full_name='Welcome Bot',
bot_owner_id=None,
is_bot=True
),
], key=by_email))