Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

tools: Remove unused `bright_red_output` context manager. 

This context manager is no longer in use since the linter visual
updates.
This commit is contained in:
Tommy Ip 2017-07-06 13:01:43 +08:00 committed by Tim Abbott
parent 2dc35e6c11
commit 61e24cfbea
1 changed files with 34 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

82
tools/lint
View File

@ -1,7 +1,6 @@
#!/usr/bin/env python #!/usr/bin/env python
from __future__ import print_function from __future__ import print_function
from __future__ import absolute_import from __future__ import absolute_import
from contextlib import contextmanager
import logging import logging
import os import os
import sys import sys
@ -17,18 +16,6 @@ sanity_check.check_venv(__file__)
import lister import lister
from typing import cast, Callable, Dict, Iterator, List from typing import cast, Callable, Dict, Iterator, List
@contextmanager
def bright_red_output():
# type: () -> Iterator[None]
# Make the lint output bright red
sys.stdout.write('\x1B[1;31m')
sys.stdout.flush()
try:
yield
finally:
# Restore normal terminal colors
sys.stdout.write('\x1B[0m')
def run_parallel(lint_functions): def run_parallel(lint_functions):
# type: (Dict[str, Callable[[], int]]) -> bool # type: (Dict[str, Callable[[], int]]) -> bool
@ -155,47 +142,46 @@ def run():
lint_functions[name] = run_linter lint_functions[name] = run_linter
with bright_red_output(): external_linter('add_class', ['tools/find-add-class'])
external_linter('add_class', ['tools/find-add-class']) external_linter('css', ['tools/check-css'], ['css'])
external_linter('css', ['tools/check-css'], ['css']) external_linter('eslint', ['node', 'node_modules/.bin/eslint', '--quiet'], ['js'])
external_linter('eslint', ['node', 'node_modules/.bin/eslint', '--quiet'], ['js']) external_linter('tslint', ['node', 'node_modules/.bin/tslint', '-c',
external_linter('tslint', ['node', 'node_modules/.bin/tslint', '-c', 'static/ts/tslint.json'], ['ts'])
'static/ts/tslint.json'], ['ts']) external_linter('puppet', ['puppet', 'parser', 'validate'], ['pp'])
external_linter('puppet', ['puppet', 'parser', 'validate'], ['pp']) external_linter('templates', ['tools/check-templates'], ['handlebars', 'html'])
external_linter('templates', ['tools/check-templates'], ['handlebars', 'html']) external_linter('urls', ['tools/check-urls'])
external_linter('urls', ['tools/check-urls']) external_linter('swagger', ['node', 'tools/check-swagger'], ['yaml'])
external_linter('swagger', ['node', 'tools/check-swagger'], ['yaml'])
# gitlint disabled until we can stabilize it more # gitlint disabled until we can stabilize it more
# if not options.no_gitlint: # if not options.no_gitlint:
# external_linter('commit_messages', ['tools/commit-message-lint']) # external_linter('commit_messages', ['tools/commit-message-lint'])
@lint
def custom_py():
# type: () -> int
failed = check_custom_checks_py()
return 1 if failed else 0
@lint
def custom_nonpy():
# type: () -> int
failed = check_custom_checks_nonpy()
return 1 if failed else 0
@lint
def pyflakes():
# type: () -> int
failed = check_pyflakes(options, by_lang)
return 1 if failed else 0
if options.pep8:
@lint @lint
def custom_py(): def pep8():
# type: () -> int # type: () -> int
failed = check_custom_checks_py() failed = check_pep8(by_lang['py'])
return 1 if failed else 0 return 1 if failed else 0
@lint failed = run_parallel(lint_functions)
def custom_nonpy():
# type: () -> int
failed = check_custom_checks_nonpy()
return 1 if failed else 0
@lint
def pyflakes():
# type: () -> int
failed = check_pyflakes(options, by_lang)
return 1 if failed else 0
if options.pep8:
@lint
def pep8():
# type: () -> int
failed = check_pep8(by_lang['py'])
return 1 if failed else 0
failed = run_parallel(lint_functions)
sys.exit(1 if failed else 0) sys.exit(1 if failed else 0)