Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

markdown: Build the emoticon regexes up front. 

There are six emoticon regexes that allow us
make translations such as ":)" to ":slight_smile".

We now build these as soon as we read in the
JSON data, instead of rebuilding them every time
we convert a message to markdown.

It's possible that we should just hardcode this
data:

    [
        { regex: /(\:\))/g, replacement_text: ':slight_smile:' },
        { regex: /(\(\:)/g, replacement_text: ':slight_smile:' },
        { regex: /(\:\/)/g, replacement_text: '😕' },
        { regex: /(<3)/g, replacement_text: '❤️' },
        { regex: /(\:\()/g, replacement_text: ':frown:' },
        { regex: /(\:\|)/g, replacement_text: '😑' }
    ]

OTOH I suppose it's possible that some server
admins will want to modify emoji_codes.json to
have custom emoticons.
This commit is contained in:
Steve Howell 2020-02-15 13:20:22 +00:00 committed by Tim Abbott
parent c9a52411ae
commit 6050a5bdd6
1 changed files with 47 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
static/js/emoji.js
View File

@ -10,6 +10,46 @@ exports.all_realm_emojis = new Map();
exports.active_realm_emojis = new Map();
exports.default_emoji_aliases = new Map();
const emoticon_translations = (() => {
/*
Build a data structure that looks like something
like this:
[
{ regex: /(\:\))/g, replacement_text: ':slight_smile:' },
{ regex: /(\(\:)/g, replacement_text: ':slight_smile:' },
{ regex: /(\:\/)/g, replacement_text: ':confused:' },
{ regex: /(<3)/g, replacement_text: ':heart:' },
{ regex: /(\:\()/g, replacement_text: ':frown:' },
{ regex: /(\:\|)/g, replacement_text: ':expressionless:' }
]
We build up this list of ~6 emoticon translations
even if page_params.translate_emoticons is false, since
that setting can be flipped via live update events.
On the other hand, we assume that emoticon_conversions
won't change until the next reload, which is fine for
now (and we want to avoid creating new regexes on
every new message).
*/
const translations = [];
for (const emoticon in emoji_codes.emoticon_conversions) {
if (emoji_codes.emoticon_conversions.hasOwnProperty(emoticon)) {
const replacement_text = emoji_codes.emoticon_conversions[emoticon];
const regex = new RegExp('(' + util.escape_regexp(emoticon) + ')', 'g');
translations.push({
regex: regex,
replacement_text: replacement_text,
});
}
}
return translations;
})();
const zulip_emoji = {
id: 'zulip',
emoji_name: 'zulip',
@ -171,12 +211,13 @@ exports.translate_emoticons_to_names = function translate_emoticons_to_names(tex
return match;
};
for (const emoticon in emoji_codes.emoticon_conversions) {
if (emoji_codes.emoticon_conversions.hasOwnProperty(emoticon)) {
replacement_text = emoji_codes.emoticon_conversions[emoticon];
const emoticon_regex = new RegExp('(' + util.escape_regexp(emoticon) + ')', 'g');
translated = translated.replace(emoticon_regex, emoticon_replacer);
}
for (const translation of emoticon_translations) {
// We can't pass replacement_text directly into
// emoticon_replacer, because emoticon_replacer is
// a callback for `replace()`. Instead we just mutate
// the `replacement_text` that the function closes on.
replacement_text = translation.replacement_text;
translated = translated.replace(translation.regex, emoticon_replacer);
}
return translated;