Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

ruff: Fix C418 Unnecessary `dict` literal passed to `dict()`. 

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2023-04-25 17:46:57 -07:00 committed by Anders Kaseorg
parent 9db3451333
commit 5ecff88c1b
1 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
zerver/lib/scim.py
View File

@ -97,24 +97,21 @@ class ZulipSCIMUser(SCIMUser):
"givenName": first_name, "givenName": first_name,
"familyName": last_name, "familyName": last_name,
} }
d = dict(
{
"schemas": [scim_constants.SchemaURI.USER],
"id": self.obj.id,
"userName": self.obj.delivery_email,
"name": name,
"displayName": self.display_name,
"active": self.obj.is_active,
# meta is a property implemented in the superclass
# TODO: The upstream implementation uses `user_profile.date_joined`
# as the value of the lastModified meta attribute, which is not
# a correct simplification. We should add proper tracking
# of this value.
"meta": self.meta,
}
)
return d return {
"schemas": [scim_constants.SchemaURI.USER],
"id": self.obj.id,
"userName": self.obj.delivery_email,
"name": name,
"displayName": self.display_name,
"active": self.obj.is_active,
# meta is a property implemented in the superclass
# TODO: The upstream implementation uses `user_profile.date_joined`
# as the value of the lastModified meta attribute, which is not
# a correct simplification. We should add proper tracking
# of this value.
"meta": self.meta,
}
def from_dict(self, d: Dict[str, Any]) -> None: def from_dict(self, d: Dict[str, Any]) -> None:
"""Consume a dictionary conforming to the SCIM User Schema. The """Consume a dictionary conforming to the SCIM User Schema. The